Comments (4)
@sander1095 is right, you don't need to take a dependency on AspNetCore for this.
You don't need all the stuff in it just for a few lines of code and the base framework offers the escape method Uri.EscapeDataString
.
I've made a PR for this.
from meilisearch-dotnet.
I think I created this issue a bit too quick!
Some more research needs to be done and I think some more discussions need to take place before this is picked up.
The source code of the QueryHelpers
class is as follows:
https://github.com/dotnet/aspnetcore/blob/main/src/Http/WebUtilities/src/QueryHelpers.cs
You can see it's a bit "enterprisey", but it does also do things like encoding URLS and all that stuff. If we care about that (which I think we do), we'd need more custom code to fill that hole with...
Read some more info about this namespace here: https://github.com/dotnet/aspnetcore/tree/main/src/Http
I do still feel a bit odd about having a dependency with aspnetcore in it's name, because it feels kind of internal to the ASP net core project and out of place here?
In any case, I guess this issue can just be closed by the maintainers if they feel this is irrelevant for now.. Otherwise, I am curious what you guys have to say!
from meilisearch-dotnet.
Hello @sander1095!
Thanks for bringing this kind of discussion, we particularly appreciate it :)
I'm not an expert in .NET projects, so I will let this issue open: I would enjoy reading the .NET community opinion about this!
from meilisearch-dotnet.
Thanks @juchom for your involvement as well! :)
from meilisearch-dotnet.
Related Issues (20)
- [v1.3] Search in facet values `facetSearch`
- [v1.3] Total Tasks in task route HOT 2
- Ensure the error handling are following the best practice
- Add CodeCov HOT 2
- Add support for custom JSON serialization options HOT 7
- Readme link to ClientFactory 404s HOT 3
- Replace the GitHub action to publish to Nugget HOT 2
- Document recommended DI usage HOT 2
- [v1.4] Support text-separator customization
- [v1.4] Support user-dictionary loading
- .net core api authorization HOT 1
- Databasesize should not be int since it can be larger than what int32 supports HOT 1
- [v1.5] Add a new method for creating snapshots
- TaskInfoStatus and TaskInfoType Types not accounted for in GetTasksAsync
- Conversion of attribute names to lower case causes subsequent error HOT 7
- Typo in property name MatchesPostion HOT 1
- [v1.6] Support `proximityPrecision` setting
- Index.UpdateDocumentsAsync() got an exception about Reflection-based serialization has been disabled for this application HOT 2
- [v.1.7] Able to use `showRankingScoreDetails` parameter at search
- [v1.8] Support `searchCutoffMs` setting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meilisearch-dotnet.