GithubHelp home page GithubHelp logo

Comments (4)

juchom avatar juchom commented on August 16, 2024 3

@sander1095 is right, you don't need to take a dependency on AspNetCore for this.

You don't need all the stuff in it just for a few lines of code and the base framework offers the escape method Uri.EscapeDataString.

I've made a PR for this.

from meilisearch-dotnet.

sander1095 avatar sander1095 commented on August 16, 2024

I think I created this issue a bit too quick!

Some more research needs to be done and I think some more discussions need to take place before this is picked up.

The source code of the QueryHelpers class is as follows:

https://github.com/dotnet/aspnetcore/blob/main/src/Http/WebUtilities/src/QueryHelpers.cs
You can see it's a bit "enterprisey", but it does also do things like encoding URLS and all that stuff. If we care about that (which I think we do), we'd need more custom code to fill that hole with...

Read some more info about this namespace here: https://github.com/dotnet/aspnetcore/tree/main/src/Http

I do still feel a bit odd about having a dependency with aspnetcore in it's name, because it feels kind of internal to the ASP net core project and out of place here?

In any case, I guess this issue can just be closed by the maintainers if they feel this is irrelevant for now.. Otherwise, I am curious what you guys have to say!

from meilisearch-dotnet.

curquiza avatar curquiza commented on August 16, 2024

Hello @sander1095!
Thanks for bringing this kind of discussion, we particularly appreciate it :)
I'm not an expert in .NET projects, so I will let this issue open: I would enjoy reading the .NET community opinion about this!

from meilisearch-dotnet.

curquiza avatar curquiza commented on August 16, 2024

Thanks @juchom for your involvement as well! :)

from meilisearch-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.