GithubHelp home page GithubHelp logo

Comments (8)

94noni avatar 94noni commented on May 18, 2024 3

Hi, I recently began to use meilisearch (for now directly with the php lib) and for POC/basic usage
I plan to integrate it inside a symfony project and thus checked this lib

I think this symfony lib could indeed leverage this kind of code but not activated by default, and let ppl activate it if needed

Also, It could be great to have some others symfony components like messenger for async update, data collector to see the underlying MS requests, and maybe some views (twig/ux) logic to ease the frontend integration

Those are just ideas on the go :)
Cheers!

from meilisearch-symfony.

curquiza avatar curquiza commented on May 18, 2024 2

If you, as symfony users, think it's a good idea, let's start this! :)

from meilisearch-symfony.

Guikingone avatar Guikingone commented on May 18, 2024 1

Hi @codedge 👋🏻

For now, I prefer to talk about this idea and see if the bundle can benefit from it, If there's a consensus about the feature, I could easily create the PR to see if it fit technically 🙂

from meilisearch-symfony.

curquiza avatar curquiza commented on May 18, 2024

Hello @Guikingone!
Nothing is planned for the moment, so every suggestion is appreciated 🙂

I'm not a Symfony user, and no one is at Meili for the moment, so can you describe how the usage would change compared to the current one we have (cf our wiki)? Or is it just a feature addition?
How can we use it? 🙂

from meilisearch-symfony.

Guikingone avatar Guikingone commented on May 18, 2024

Hi @curquiza 👋🏻

so can you describe how the usage would change compared to the current one we have (cf our wiki)? Or is it just a feature addition?

It's a feature addition

Advantages:

  • Use indexes and documents inside a form to display choices and speed search experience (when using SearchType)
  • Being able to create form that use MS without pain as a default type handle the configuration and results.
  • Allow to create a complete "search experience" without pain and a "deep" Symfony integration

Disadvantages:

  • Inject the SearchService into a type (which lead to a relation between the search experience and the Symfony architecture)
  • The error handling must be done in the type, so if MS fails, the form will too.

There might be some edge issues that I don't have in mind but IMHO, the feature could be interesting 🙂

from meilisearch-symfony.

curquiza avatar curquiza commented on May 18, 2024

As I'm not a Symfony user I cannot tell if it's worth it to add it, I mean if the pros neutralize the cons! 🙂

Maybe @codedge you have an opinion on it? 😇

Also, if someone around here is from the PHP/Symfony community and read this issue, feel free to comment and give your opinion.

from meilisearch-symfony.

Guikingone avatar Guikingone commented on May 18, 2024

@94noni I fully agree for both Messenger support and DataCollector support 🚀

from meilisearch-symfony.

codedge avatar codedge commented on May 18, 2024

@Guikingone Anything that speaks against using your custom form type https://github.com/Guikingone/MeiliSearchBundle/blob/master/src/Form/Type/MeiliSearchChoiceType.php from being used here? I mean could you create a PR?

from meilisearch-symfony.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.