PatternBuilder SetProgram method not working with ToTrackChunk method about drywetmidi

[melanchall]

Oh sorry, I forgot to set Channel property on event returned by GetProgramEvent:

var programChangeEvent = (ProgramChangeEvent)GeneralMidiProgram.Pad8.GetProgramEvent();
programChangeEvent.Channel = (FourBitNumber)1;
chordTrackChunk.Events.Insert(0, programChangeEvent);

@meckzqz, can the issue be closed?

[melanchall]

Hi,

I confirm the issue. I've fixed it in develop branch and the fix will be available in next release of the library. At now you have several options to work around the issue:

• Build the library from sources of the develop branch

• Wait for the next release

• Insert ProgramChangeEvent at start of track chunk after ToTrackChunk call:

  var trackChunk = patternBuilder.Build().ToTrackChunk(TempoMap.Default, (FourBitNumber)1);
  trackChunk.Events.Insert(0, GeneralMidiProgram.Accordion.GetProgramEvent());

[meckzqz]

Hello,

The quick turnaround time on this is much appreciated. I have tried using the solution you've proposed, and the results are unchanged from my previous report.

The code in question:

var trackChunk = patternBuilder.Build().ToTrackChunk(TempoMap.Default, (FourBitNumber)0);
trackChunk.Events.Insert(0, GeneralMidiProgram.Accordion.GetProgramEvent());
var chordTrackChunk = chordPatternBuilder.Build().ToTrackChunk(TempoMap.Default, (FourBitNumber)1);
chordTrackChunk.Events.Insert(0, GeneralMidiProgram.Pad8.GetProgramEvent());
MidiFile midiFile = new MidiFile(new[]
{
    trackChunk,
    chordTrackChunk
});

I'm prepared to switch to the develop branch for now, but I'm confused as to why this code isn't functioning as expected.

EDIT: I now realize your proposed solution understandably assumes a program change on a single TrackChunk, and likely doesn't account for this specific case.

EDIT2: Trying out the develop code now, and everything seems to be working as expected. Kudos!