[bug] Several Nodes will not install about comfy_mtb

[melMass]

Hi,

Thanks again for the report and the kind words,
If you can check and provide the log of the install it should help a lot, I tried to give meaningful feedback to what the issues might be.

That being said, the install script also has a "CLI" mode with arguments:

/path/to/comfy_embedded/python.exe ComfyUI/custom_nodes/comfy_mtb/install.py --help

usage: install.py [-h] [--path PATH] [--wheels] [--requirements] [--dry]

Comfy_mtb install script

options:
  -h, --help            show this help message and exit
  --path PATH, -p PATH  Path to clone the repository to (i.e the absolute path to ComfyUI/custom_nodes)
  --wheels, -w          Install wheel dependencies
  --requirements, -r    Install requirements.txt
  --dry                 Print what will happen without doing it (still making requests to the GH Api)

If this doesn't sound too complex you can try the following:

/path/to/comfy_embedded/python.exe ComfyUI/custom_nodes/comfy_mtb/install.py -w

[ricklove]

@melMass btw, great work!

(For others finding this as a related issue.)

Mine also failed to install fully through the ComfyUI Manager:

[comfy_mtb] | INFO -> Some nodes failed to load:
        Failed to import module faceenhance because ModuleNotFoundError: No module named 'basicsr'
        Failed to import module faceswap because ModuleNotFoundError: No module named 'insightface'
        Failed to import module fun because ModuleNotFoundError: No module named 'qrcode'
        Failed to import module image_interpolation because ModuleNotFoundError: No module named 'tensorflow'

Check that you properly installed the dependencies.

But installing from cli cleared it up:

./python_embeded/python.exe ComfyUI/custom_nodes/comfy_mtb/install.py -w

---

Update 1:

Spoke to soon - that seems to have broke my comfyui:

AssertionError: Torch not compiled with CUDA enabled

---

Update 2:

Ok, had to reinstall torch (which meant I had to figure out how to run pip in the embedded python). This worked:

(pip commands are from comfyui readme manual install section, but modified to run in the embedded python)

./python_embeded/python.exe -m pip uninstall torch

./python_embeded/python.exe -m pip install torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/cu118 xformers

Now, ComfyUI is working and I can run the FILM workflow

Note: The FILM model didn't auto install, so resolving that (according to mtb readme):

./python_embeded/python.exe ComfyUI/custom_nodes/comfy_mtb/scripts/download_models.py -y

Also one node still didn't install:

[comfy_mtb] | INFO -> Some nodes failed to load:
        Failed to import module faceswap because ModuleNotFoundError: No module named 'insightface'

but closer.

[AIMusicExperiment]

I will now be slashing my veins, so feel free to read my obituary. . . in spite of vowing that I wasn't going to mess with this any more, I did a new install from a git clone using the parameters that you discussed, and I also installed the models again using the parameters that you discussed. The install log said that all dependencies were successfully installed, and all the modals said that they correctly installed.

when I started ComfyUI the log showed the exact crap that I've been looking at for days now.

When I opened the GUI ComfyUI was completely broken. The only way to make it work is to remove you folder. This has become a complete nightmare, now I cannot only not us the nodes in question, but I can't use any of your nodes.

This has basically fucked my world, as I'm working on a workflow that uses a bunch of your other nodes and they don't work either. Frankly, I should have just been happy and not tried to swap faces. So lifes a bitch!

[AIMusicExperiment]

Thanks for abandoning us!

[AIMusicExperiment]

Mel, I have been nothing but complimentary to you, I simply expressed that I was frustrated that I couldn't get the app to work. You have indeed offered a lot of help, but I have not been able to make your guidance work, When I finally had what looked like success, the entire comphy failed. If you reread my earlier comment, you will see that it had nothing to do with you. I was doubly frustrated when I saw that you simply closed the issue, rather than responding. I think if you reread my comments here and also on the previous conversation you will remember that I have been very complimentary of you and your work. As we have discussed earlier, I am a YouTube content creator and I am working on a video that highlights your nodes for animation.

Your level expertise can make it difficult for you to understand that regular users like myself don't have any idea what a python embedded environment is, or how that is affecting the install process. Many don't even understand how to use the command prompt, and have never heard of window shell. Not understanding your advice is not ignoring your advice. My experience with other custom nodes is that I click install on the manager and then when I restart CompyUI it works. I think that many others are of that mindset. Bottom line, my frustration is not and should not be seen as a reflection on you .

GraphiTom, this is none of your fucking business! You jumped on to my issue and though welcomed, did nothing to help. I will not be judged by you as you have no understanding of me, my position, nor my background. I don't have the attitude of entitlement, but I do need for these nodes to work in order to do my work. It is immaterial as to the cost of the software, as I and my colleagues routinely compensate developers through Patreon, or "buy me a coffee." My best advice to you is to mind your own business. BTW I love that Karma stepped in and broke you app!

[GrafiTom]

Your last comment was really *misunderstandable*. Not only by me but be the OP too. I was forming a general opinion what I experience lately online. I had a guy asking for help on discord, I helped him in video editing, then next day he came for more, asking to do it form him. etc. Then was totally angry when I told him he should educate on the matter and try it on his own. If you are the exception then *I apologise*. You have to admit that your comment was weird. Maybe a smiley next time helps. Loving that my app broke is interesting approach too. Hope you will work out with mtb nodes and can progress with your work. #Mel keep up the good work! Have a nice day guys!

…

On Wed, Aug 9, 2023 at 5:49 PM AIMusicExperiment ***@***.***> wrote: Mel, I have been nothing but complimentary to you, I simply expressed that I was frustrated that I couldn't get the app to work. You have indeed offered a lot of help, but I have not been able to make your guidance work, When I finally had what looked like success, the entire comphy failed. If you reread my earlier comment, you will see that it had nothing to do with you. I was doubly frustrated when I saw that you simply closed the issue, rather than responding. I think if you reread my comments here and also on the previous conversation you will remember that I have been very complimentary of you and your work. As we have discussed earlier, I am a YouTube content creator and I am working on a video that highlights your nodes for animation. Your level expertise can make it difficult for you to understand that regular users like myself don't have any idea what a python embedded environment is, or how that is affecting the install process. Many don't even understand how to use the command prompt, and have never heard of window shell. Not understanding your advice is not ignoring your advice. My experience with other custom nodes is that I click install on the manager and then when I restart CompyUI it works. I think that many others are of that mindset. Bottom line, my frustration is not and should not be seen as a reflection on you . GraphiTom, this is none of your fucking business! You jumped on to my issue and though welcomed, did nothing to help. I will not be judged by you as you have no understanding of me, my position, nor my background. I don't have the attitude of entitlement, but I do need for these nodes to work in order to do my work. It is immaterial as to the cost of the software, as I and my colleagues routinely compensate developers through Patreon, or "buy me a coffee." My best advice to you is to mind your own business. BTW I love that Karma stepped in and broke you app! — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJKYRMTKNAUJ3T6E4SOWSHLXUOWQ7ANCNFSM6AAAAAA3FL4J4M> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[AIMusicExperiment]

I tried but just had cmd tell me that it couldn't find the path. . .Between a rock and hard place, because I don't want to lose the node that I have in order to get the ones I need. Is there an easier way to fix this?

[GoldmanOz]

I'm also having issues with nodes not installing, have installed through Comfy manager, and git pulled, everything telling me all is good until I try to load the face swap .json file then I'm getting the dreaded red nodes, won't update through the missing nodes function on the manager... I'm on an M1 MacBook Pro.. ????

[melMass]

Can you provide the log of the install steps? I fully tested mtb on my m1 but not through comfy-manager

It should start like this:

It's the 📦 Install mtb nodes step here: https://github.com/melMass/comfy_mtb/actions/runs/5750681075/job/15587944434

[EricRollei]

Hi Mel, I'm also having trouble getting all the nodes to install. I'm using the latest nightly windows portable build, have taken your previous advice and downloaded pyenv and created a local env for ComfyUI and installed Python 3.11 for that. Here's my console output:

Log level: 20
RestoreFace
LoadFaceEnhanceModel
FaceSwap
LoadFaceSwapModel
LoadFaceAnalysisModel
QrCode
UnsplashImage
LoadFilmModel
FilmInterpolation
ConcatImages
GetBatchFromHistory
[comfy_mtb] | INFO -> Some nodes failed to load:
Failed to import module faceenhance because ModuleNotFoundError: No module named 'basicsr'
Failed to import module faceswap because ModuleNotFoundError: No module named 'insightface'
Failed to import module fun because ModuleNotFoundError: No module named 'qrcode'
Failed to import module image_interpolation because ModuleNotFoundError: No module named 'tensorflow'

I've got some of these modules in previous installs of mtb nodes in other folders.... but I'll try using your install commands.

Do I need to delete the mtb folder in the ComfyUI/web/extensions/ folder for updates and re-installs?

[EricRollei]

ps if I run the install.py with -w --dry this is what I get in the console

A:\Comfy_Aug> A:/Comfy_Aug/python_embeded/python.exe A:/Comfy_Aug/ComfyUI/custom_nodes/comfy_mtb/install.py -w --dry
[mtb install] Detected environment: embeded
[mtb install] Downloading and installing release wheels since we are in a Comfy embeded environment
✅ Package onnxruntime-gpu already installed (import name: 'onnxruntime').
⛔ Package qrcode is missing (import name: 'qrcode').
✅ Package rembg already installed (import name: 'rembg').
⛔ Package tensorflow is missing (import name: 'tensorflow').
⛔ Package tb-nightly is missing (import name: 'tensorboard').
⛔ Package tensorflow is missing (import name: 'tensorflow').
⛔ Package facexlib is missing (import name: 'facexlib').
⛔ Package insightface is missing (import name: 'insightface').
⛔ Package basicsr is missing (import name: 'basicsr').
[mtb install] ⚙️ Sorting the release wheels using wheels order
[mtb install] Would have run the following command:
A:\Comfy_Aug\python_embeded\python.exe -m pip install

I'm kind of scared to do it because this is how my comfy usually gets broken - the dependencies and stuff. Let me back it up first, then I'll try it for real.

[EricRollei]

Okay here's the console when I run that install.py command for real and I think explains the issue? I am using Windows 11 by the way:

A:\Comfy_Aug> A:/Comfy_Aug/python_embeded/python.exe A:/Comfy_Aug/ComfyUI/custom_nodes/comfy_mtb/install.py -w
[mtb install] Detected environment: embeded
[mtb install] Downloading and installing release wheels since we are in a Comfy embeded environment
✅ Package onnxruntime-gpu already installed (import name: 'onnxruntime').
⛔ Package qrcode is missing (import name: 'qrcode').
✅ Package rembg already installed (import name: 'rembg').
⛔ Package tensorflow is missing (import name: 'tensorflow').
⛔ Package tb-nightly is missing (import name: 'tensorboard').
⛔ Package tensorflow is missing (import name: 'tensorflow').
⛔ Package facexlib is missing (import name: 'facexlib').
⛔ Package insightface is missing (import name: 'insightface').
⛔ Package basicsr is missing (import name: 'basicsr').
[mtb install] ⚙️ Sorting the release wheels using wheels order
ERROR: pycocotools-2.0.6-cp310-cp310-win_amd64.whl is not a supported wheel on this platform.
Command failed with return code: 1
Ignoring tensorflow: markers 'platform_system != "Windows"' don't match your environment
Collecting onnxruntime-gpu==1.15.1 (from -r A:/Comfy_Aug/ComfyUI/custom_nodes/comfy_mtb/reqs.txt (line 1))
Obtaining dependency information for onnxruntime-gpu==1.15.1 from https://files.pythonhosted.org/packages/88/07/19f9ad96b9f3540883ae14276b98e2785b93ed40ba7247e682c98422af4a/onnxruntime_gpu-1.15.1-cp311-cp311-win_amd64.whl.metadata
Using cached onnxruntime_gpu-1.15.1-cp311-cp311-win_amd64.whl.metadata (4.1 kB)
Collecting qrcode[pil] (from -r A:/Comfy_Aug/ComfyUI/custom_nodes/comfy_mtb/reqs.txt (line 2))
Using cached qrcode-7.4.2-py3-none-any.whl (46 kB)
Requirement already satisfied: rembg==2.0.50 in a:\comfy_aug\python_embeded\lib\site-packages (from -r A:/Comfy_Aug/ComfyUI/custom_nodes/comfy_mtb/reqs.txt (line 3)) (2.0.50)
ERROR: Could not find a version that satisfies the requirement tensorflow==2.10.1 (from versions: 2.12.0rc0, 2.12.0rc1, 2.12.0, 2.12.1, 2.13.0rc0, 2.13.0rc1, 2.13.0rc2, 2.13.0)
ERROR: No matching distribution found for tensorflow==2.10.1
Command failed with return code: 1
[mtb install] ✅ Successfully installed all dependencies.

[AIMusicExperiment]

Hi again, I see that my problem isn't in isolation. Can you update as to whether you have found a solution? Your nodes that are working for me are SO GOOD, I'm pretty sure that the ones I can't get to install wood be super helpful. Please advise.

[melMass]

Hi everyone subscribed to this issue. Please open dedicated issues, you all have different cases...

@EricRollei 3.11 is not compatible with the tf version required as you can see in the log. Besides that the install went as expected

[melMass]

@AIMusicExperiment can you provide some log? (#52 (comment))

[GrafiTom]

./python_embeded/python.exe ComfyUI/custom_nodes/comfy_mtb/install.py -w

It helped me to clear up 3 of the 4 missing modules. I only have one left.

[GrafiTom]

and still...

[AIMusicExperiment]

Okay things are just getting worse for me. It is probably my fault, but in spite of spending hours on the (which frankly I don't have) I can not get this to work. It is likely that I just don't have the level of command line expertise that is necessary, but I can't make that ./python_embeded/python.exe ComfyUI/custom_nodes/comfy_mtb/scripts/download_models.py -y thing that is working for others do anything. If I execute that command cmd says that the path or file can't be found. Perhaps I need more instruction.
I saw that you updated the commit since yesterday, so I deleted and reinstalled through manager and also from a "git clone" with either method the new repository, the extension completely breaks CompyUi. :(

Compy UI opens, and if I load the default workflow, all the nodes are in red, and the manager is gone. As soon as I delete the MTB folder and restart everything else works fine.

I love and need your nodes, but I have spent so much time down this rabbit hole that I just can't anymore.

You have asked for logs, but they are alll the same as the first one I posted. Thanks for you help!

[melMass]

@AIMusicExperiment
Those are both file paths: ./python_embeded/python.exe & ComfyUI/custom_nodes/comfy_mtb/scripts/download_models.py, just find them on disk (the first is your ComfyPortable python.exe) the second this file https://github.com/melMass/comfy_mtb/blob/main/scripts/download_models.py that should be where I pointed you but it depends from where you are running it, you can use absolute paths.

You can also just find those path on disk and drag and drop them to the terminal, I personally use the Windows Terminal, but I think you can too in the basic cmd version.

[GrafiTom]

Any idea about my issue? My only error left is the tensorflow module..
everything installed the hard way :)

[melMass]

@GrafiTom Detected environment: unknown is definitely the issue!

Are you using comfy portable?

If so please provide the full path to the python executable although looking at the picture it seems you are probably mixing python environments :/

[GrafiTom]

Thanks for your answer.  Yeah, I guess that can be the problem. I am total noob to programming. I am running portable Comfy UI and everything works great. But the I wanted to check out mtb nodes and fell into the rabbit hole. :)So portable version uses its own embeded python? and it conflicts with the python installed on my system? What should I try?

[melMass]

So portable version uses its own embeded python?

yes, the path should look something like ComfyPortable/python-embeded/python.exe and you want to use this to install dependencies in the portable version, there you installed them in your "global" system python

[GrafiTom]

Okay thanks! Will try that in the morning.  

[melMass]

I'm seriously going to loose patience with this kind of attitude... you don't feel like I'm trying to help?
I explained a point completely ignored here: #52 (comment)

[GrafiTom]

This is just basic attitude nowadays. :( People feel that they deserve support for a free, experimental code. Btw thanks for clearing up yesterday that embeded problem. I made a big step forward. Now every module loads fine, I can use examples 2,3,4 The only thing left is faceswap.. that missing nodes

…

On Wed, Aug 9, 2023 at 9:43 AM Mel Massadian ***@***.***> wrote: I'm seriously going to loose patience with this kind of attitude... you don't feel like I'm trying to help? I explained a point completely ignored here: #52 (comment) <#52 (comment)> — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJKYRMQGMSQZNMCL24GNCI3XUM5TZANCNFSM6AAAAAA3FL4J4M> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[melMass]

Thanks yes it's just frustrating when you dedicate time and are thanked like that 😅

The only thing left is faceswap.. that missing nodes

Can you open an issue? I think I found the remaining issues about install and will fix it in the next release, trackable at #50

[GrafiTom]

Well I just messed up something, and Comfy won't even start.. so made a fresh install. Now I am with a basic working ComfyUI portable. Which way is the recommended? :) Run the commands manually from python_embeded folder?

…

On Wed, Aug 9, 2023 at 12:18 PM Mel Massadian ***@***.***> wrote: Thanks yes it's just frustrating when you dedicate time and are thanked like that 😅 The only thing left is faceswap.. that missing nodes Can you open an issue? I think I found the remaining issues about install and will fix it in the next release, trackable at #50 <#50> — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJKYRMVUPGMX54J4CUIGC4TXUNPXFANCNFSM6AAAAAA3FL4J4M> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[melMass]

@AIMusicExperiment

Bottom line, my frustration is not and should not be seen as a reflection on you .

I might have overreacted because of previous similar behavior and frustration from my side and I woke up to your comment.
That said the main reason I closed this issue is the title being so generic 5 different users commented here instead of opening an issue, while the end result was mostly the same: some nodes won't install. Dealing with all those cases in the same thread is much more complicated, ideally 1 issue = 1 case, unless it's specific enough.

Your level expertise can make it difficult for you to understand that regular users like myself don't have any idea what a python embedded environment is, or how that is affecting the install process.

I can definitely understand that my perspective is not always the best but I try to clarify as much as possible, I'm definitely not perfect at it and the dependencies needed by some node are really not helping me 😅

My experience with other custom nodes is that I click install on the manager and then when I restart CompyUI it works.

That's definitely the end goal and being an "early" adopter means you are seing this getting into shape (this phase took more thought and time than I initially expected), I did get some valuable info from the cases explained here in the end that I will implement in #50. I'm currently simplyfing a lot the install process and adding utilities to download dependencies and model from the UI directly:

[melMass]

I should finish this today or tomorrow max. I just need a better testing suite

[EricRollei]

Hi Mel,
I didn't comment further since you identified that my install went ok other than the parts which aren't compatible with Python 3.11
I hope it's ok to make one post just to say I'm really thankful for your work here with these nodes. If I do another comfy install, what's the highest version of Python that is compatible with your nodes?

[melMass]

I didn't comment further since you identified that my install went ok

If you have further issues don't hesitate to open a new issue anytime! I would just wait for 0.1.4 since it should clear up an issue specific to windows embedded mode.

If I do another comfy install, what's the highest version of Python that is compatible with your nodes?

On linux and mac any version of python that is compatible with Comfy, on windows any 3.10.X, On windows I personally use a shared virtualenv for A1111 & Comfy on python 3.10.11, on my mac m1 python 3.11.
Another option I'm thinking of doing is ship tensorflow cpu by default (since we can use the latest on windows too) and optionally add a way to install the gpu one (that requires an older tensorflow on windows), the main reason being the FILM interpolation nodes that are REALLY slow on CPU (like several minutes) and REALLY fast on GPU (like a few seconds)