Create a INSTALL file explaning how to compile ONLY bucket_engine about bucket_engine

[trondn]

See: http://www.couchbase.com/wiki/display/couchbase/Building+Couchbase+from+Source

Cheers

Trond

[shakaran]

@trondn I just read that webpage, but it imply download all couch-server package with the versions bundled in the tar.gz. I mean in that tar.gz you ship a exact version of memcache, ep-engine and others. I want compile the current git master of ep-engine from github. It only fails in ep-engine from github (I already note that it works compiling via the couchbase-server). So, could you please give instruction about only compile ep-engine from github?

For example, I see that mc_extension_token_t is not declared, but grepping in couch base server it is declared in couchbase-server_src/memcached/include/memcached/extension.h line 127.

But I have compiled that memcached with engine-pu and it still fails. So, what it is different from github memcache branch engine-pu and the current memcached shipped as bundle in couchbase-server?

[avsej]

It also described in the README file https://github.com/couchbase/manifest#readme

$ mkdir couchbase
$ cd couchbase
$ repo init -u git://github.com/couchbase/manifest.git -m 2.1-unstable.xml
$ repo sync
$ make

It will put server installation into couchbase/install prefix

[trondn]

In order to do that you need the "correct" memcached version with its headers (you'll find that in the bundle we ship).

[shakaran]

@trondn I am having the same issue trying this:

./configure --with-memcached=../memcached-engine-pu
make

It is the right way to correct memcached version with its headers? I don't know if you are refering to other changes in the bundle that I have to perform in my git build.

[trondn]

If you want to use bucket_engine you're going to want to use the corresponding memcached version from our memcached git repository.

[shakaran]

Ok, I suppose that bucket_engine is using the memcached original repo. My bad.

I compile now this:

git clone -b engine --single-branch git://github.com/membase/memcached.git memcached-membase
cd memcached-membase; sh config/autorun.sh;
./configure; make; make install

Then I pass the folder of compilation to ep-engine:

./configure --with-memcached=../memcached-membase

But I still get the same failures, so what I still doing wrong?

[trondn]

Check the include path the compiler is using and see if you have some of the memcached headers earlier in that path.. if so you're getting the wrong header...

We don't really support building this isolated due to a resource issue on our side... The easiest way to build bucket engine is to follow the instruction outlined above

[shakaran]

It doesn't seem a memcached headers problem.

I am seeing now the problem. For example for this small change:

git diff ../memcached-membase/include/memcached/extension.h ../couchbase-server/couchbase-server_src/memcached/include/memcached/extension.h 
diff --git a/../memcached-membase/include/memcached/extension.h b/../couchbase-server/couchbase-server_src/memcached/include/memcached/extension.h
index 6ec0040..e807709 100644
--- a/../memcached-membase/include/memcached/extension.h
+++ b/../couchbase-server/couchbase-server_src/memcached/include/memcached/extension.h
@@ -2,7 +2,10 @@
 #ifndef MEMCACHED_EXTENSION_H
 #define MEMCACHED_EXTENSION_H

+#ifndef __cplusplus
 #include <stdbool.h>
+#endif
+
 #include <stdint.h>
 #include <memcached/engine_common.h>
 #include <memcached/protocol_binary.h>
@@ -121,7 +124,7 @@ extern "C" {
     typedef struct {
         char *value;
         size_t length;
-    } token_t;
+    } mc_extension_token_t;

     /**
      * ASCII protocol extensions must provide the following descriptor to
@@ -165,7 +168,7 @@ extern "C" {
         bool (*accept)(const void *cmd_cookie,
                        void *cookie,
                        int argc,
-                       token_t *argv,
+                       mc_extension_token_t *argv,
                        size_t *ndata,
                        char **ptr);

@@ -181,7 +184,7 @@ extern "C" {
          */
         ENGINE_ERROR_CODE (*execute)(const void *cmd_cookie,
                                      const void *cookie,
-                                     int argc, token_t *argv,
+                                     int argc, mc_extension_token_t *argv,
                                      ENGINE_ERROR_CODE (*response_handler)(const void *cookie,
                                                                            int nbytes,
                                                                            const char *dta));

In memcached membase git there are not the same code that you bundled with couchbase-server memcached folder. Why is not the same content? It is not pushed the new content to git memcached repository? It seems that only a bit files differs with small changes.

Now I can compile with:

./configure --with-memcached=../couchbase-server/couchbase-server_src/memcached/

But I would like that memcached membase git repository ships the same changes of couchbase-server.

[trondn]

Are you using the correct branch in the memcached repository ;) we're building multiple versions, and you would have to use the correct manifest file to find the correct version to use

Trond

[shakaran]

Thanks trondn, picking the master branch of memcache membase I can compile now without problems. Before I was picking the engine branch (as recommended in github readme). Thanks for your support.