GithubHelp home page GithubHelp logo

Comments (2)

DavIvek avatar DavIvek commented on June 25, 2024

The problem is that Memgraph saves the current timestamp only in DiskStorage destructor, but if process gets killed with SIGKILL signal, for example, then destructor won't be called and the timestamp won't be saved.
Because of that, timestamp will start from 1 and old keys will be used, hence user will have to query the database until he gets to the timestamp he used before database was restarted.
To fix this, we should either save every commit timestamp after the transaction finishes, or we could add a flag that will save the timestamp after n commits.

from memgraph.

DavIvek avatar DavIvek commented on June 25, 2024

An additional issue related to this one, the --data-recovery-on-startup flag doesn't do anything in on-disk storage mode. By default, Memgraph is treating it as always true. We should either handle the case where it is set to false (by deleting rocksdb data dirs) or we should write somewhere in docs, that if the user doesn't want to recover data on startup, he should delete rocksdb data dirs manually.

from memgraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.