Runtime error when trying to read project_id from default google creds about rele

[Itsindigo]

@andrewgy8 sounds like a good solution to me 👍

[andrewgy8]

Hey @Itsindigo ! Is this still an issue if you dont have the key GC_CREDENTIALS_PATH defined in your config?

[Itsindigo]

@andrewgy8 it will run if you delete the key, yes

[andrewgy8]

In that case Im not sure its a bug, as it is working as expected. Would clarifying the configuration options in the documentation solve this?

[Itsindigo]

Ah, sorry @andrewgy8 -- it is a bug. I forgot to clear out my .env and was still authenticating as a service account.

rele.config.setup({'APP_NAME': 'smart_comms_planner', 'MIDDLEWARE': ['rele.contrib.LoggingMiddleware', 'rele.contrib.FlaskMiddleware']}, flask_app=app)

This will bug with:

Exception has occurred: AttributeError
'Credentials' object has no attribute 'project_id'

Think a fix is needed

[Itsindigo]

I'll add some tests shortly.

How do I run the suite? I've sourced a virtualenv and installed the deps, running make test fails on these:

================================= short test summary info ==================================
FAILED tests/test_client.py::TestSubscriber::test_creates_subscription_with_default_ack_deadline_when_none_provided
FAILED tests/test_client.py::TestSubscriber::test_creates_subscription_with_custom_ack_deadline_when_provided
FAILED tests/test_config.py::TestConfig::test_parses_all_keys - AssertionError: assert No...
FAILED tests/test_config.py::TestConfig::test_inits_service_account_creds_when_credential_path_given
FAILED tests/test_config.py::TestConfig::test_sets_defaults_pulled_from_env - AssertionEr...
FAILED tests/test_worker.py::TestWorker::test_creates_subscription_with_custom_ack_deadline_from_environment
FAILED tests/test_worker.py::TestCreateAndRun::test_waits_forever_when_called_with_config_and_subs
FAILED tests/commands/test_runrele.py::TestRunReleCommand::test_calls_worker_start_and_setup_when_runrele
========================= 8 failed, 56 passed, 4 warnings in 1.46s =========================
make: *** [test] Error 1

[andrewgy8]

Was it fixed @Itsindigo ? In order to see why the tests are failing, I would have to see the stack trace or the failing out put of one of the tests.