GithubHelp home page GithubHelp logo

[DISCUSSION] UI Improvements about anvio HOT 21 OPEN

meren avatar meren commented on July 26, 2024
[DISCUSSION] UI Improvements

from anvio.

Comments (21)

meren avatar meren commented on July 26, 2024 1

This is how the detailed taxonomy estimation panel looked like in the original version:

image

And how it looks like now (not very pretty, is it):

image

This is what happened when someone clicked on a bin in that window:

image

And this is what happens now (i.e., nothing :)):

image

from anvio.

meren avatar meren commented on July 26, 2024 1

When there are no legends to be shown, under the legends section, in light gray, it should say,

"There are no legends to edit in this display."

It currently looks empty and confusing:

image

from anvio.

meren avatar meren commented on July 26, 2024 1

ABORT ABORT. Please don't make any changes for this one and ignore everything below this line :)


Please remove these two items from the options panel,

image

And make custom margins turned on by default in the main panel as the following:

image

There are multiple reasons for this. Options is a new panel, and this change affects the structure of the main panel, which is not what people are looking at when the button is clicked (in the old design it was under additional settings in the main panel, so it made it more intuitive). Now we have more space in the main panel, so there is no reason to not have them turned on by default.

from anvio.

meren avatar meren commented on July 26, 2024 1

Please expand the width of the dropbox so the text fits (and replace 'leaf' with 'item' in the text):

image

from anvio.

meren avatar meren commented on July 26, 2024 1

It is "anvi'o" (and not capitalized when it occurs in mid-sentence like a regular word). I saw this in multiple places in the interface, and I thought I'd point it it out :)

image

from anvio.

meren avatar meren commented on July 26, 2024 1

In the pangenome, gene cluster functions window looked like this when one clicked on the button in the bins panel:

image

And it looks like this now:

image

I think the content is much less readable. Please adjust the window and font size to have a comparable view.

from anvio.

meren avatar meren commented on July 26, 2024 1

The link here is broken and goes to pull requests page:

image

from anvio.

meren avatar meren commented on July 26, 2024

Show grids button doesn't work (as in, you click on it, but grids are not shown for selections):

image

Plus, the color picker in the same control doesn't respond when clicked.

from anvio.

metehaansever avatar metehaansever commented on July 26, 2024

I'm on it! Thank you Meren

from anvio.

meren avatar meren commented on July 26, 2024

This is the font-face in the original interface:

image

And this is how it is in the ui-improvements:

image

from anvio.

metehaansever avatar metehaansever commented on July 26, 2024

This is the font-face in the original interface:

image And this is how it is in the `ui-improvements`: image

Actually I did that in purpose. I replaced every font with "Montserrat", with some exceptions. The reason for this was to have the same typography everywhere.

from anvio.

meren avatar meren commented on July 26, 2024

Actually I did that in purpose. I replaced every font with "Montserrat", with some exceptions. The reason for this was to have the same typography everywhere.

And yet it is not working. This is how it looks on my interface right now:

image

And this is how it would have looked like if it was in Montserrat:

image

I'm not sure if it may be because MacOS is missing Montserrat in its default font collection? You can probably solve it by including Montserrat with the anvi'o distribution, but I think it would be much better to not do that and use Helvetica as we did before. Because people will download SVGs to work with anvi'o outputs, and then every font in the SVG will be replaced with Times New Roman just because they don't have Montserrat in their collection.

from anvio.

meren avatar meren commented on July 26, 2024

"Search gene clusters using filters" should have the same size with every other header on this page.

image

And this section is mean to serve all three search options, but it is not clear anymore:

image

I'm not sure how to make it obvious now we are not collapsing individual search strategies :/

from anvio.

metehaansever avatar metehaansever commented on July 26, 2024

Show grids button doesn't work (as in, you click on it, but grids are not shown for selections):

image

image

when I test Show Width color and width works for me.

from anvio.

metehaansever avatar metehaansever commented on July 26, 2024

Actually I did that in purpose. I replaced every font with "Montserrat", with some exceptions. The reason for this was to have the same typography everywhere.

And yet it is not working. This is how it looks on my interface right now:

image And this is how it would have looked like if it was in Montserrat: image I'm not sure if it may be because MacOS is missing Montserrat in its default font collection? You can probably solve it by including Montserrat with the anvi'o distribution, but I think it would be much better to not do that and use Helvetica as we did before. Because people will download SVGs to work with anvi'o outputs, and then every font in the SVG will be replaced with Times New Roman just because they don't have Montserrat in their collection.

I wasn't consider that and Montserrat wasnt one of the default font so I switched all font-family to Helvetica.

from anvio.

metehaansever avatar metehaansever commented on July 26, 2024

@meren Meren, I fixed every bug in here. I'll run anvio tutorials tomorrow and update here with newer bugs. :feelsgood:

from anvio.

xvazquezc avatar xvazquezc commented on July 26, 2024

Given that you are dealing with fonts, worth mentioning that Helvetica is only included in Mac, it isn't standard with any other OS due to licensing.
If the issue is folks not having the font in the system for the SVGs, the font can be embeded in them - likely a very small increase in size in comparison with the whole SVG

from anvio.

meren avatar meren commented on July 26, 2024

That's a great point, @xvazquezc. @metehaansever, can you please look into this and figure out if we can display and export SVG images regardless of the font collection on the user side?

Although my top choice among all the open-source fonts similar to Helvetica is Inter, it doesn't have italicised alternative for black 900 (which has been a huge problem for us forever as it is the case with Helvetica). So I think we should go with Roboto. Can you please make the necessary changes and see if you can display and export SVGs to work with inkscape on them, including on computers without Roboto installed?

from anvio.

metehaansever avatar metehaansever commented on July 26, 2024

@meren Helvetica is default font for Unix and Macos actually. I tried to Svg export and Helvetica works on my Ubuntu 22.04.
I'll try to embed font-family inside SVG and if its work, i'll update rest with Roboto.

from anvio.

metehaansever avatar metehaansever commented on July 26, 2024

"Search gene clusters using filters" should have the same size with every other header on this page.

image And this section is mean to serve all three search options, but it is not clear anymore: image I'm not sure how to make it obvious now we are not collapsing individual search strategies :/

Default:

Search With expression:

Search Functions:

And gene cluster version will be yellow :)

from anvio.

xvazquezc avatar xvazquezc commented on July 26, 2024

@metehaansever maybe other Unix, but definitely not Linux. I've been running Ubuntu by default since 16.04 and it was already missing back then. Definitely still not in 22.04.1... and I prob have more fonts than any sane person.

Screenshot at 2023-12-08 15-01-32

Note that even if you tell to use Helvetica, most programs, CSS... will use something else if not available. That's why a good website/CSS normally have a few fonts listed as fallback to limit the differences in appearance if the main font is not available

from anvio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.