GithubHelp home page GithubHelp logo

Comments (5)

DevRish avatar DevRish commented on July 21, 2024

Hi @aabidsofi19 @leecalcote . I would like to work on this issue. It would be my first time contributing here, so I appreciate some guidance.

I found the existing workflow at

, found the playwright tests at https://github.com/meshery/meshery/tree/master/ui/tests/e2e and found the test-setup-ui and test-ui goals in the Makefile that run the commands to run the e2e tests.

So, I'm thinking of replacing the cypress test steps with a step that runs make test-setup-ui and make test-ui, which run the playwright tests. Is this the correct approach?

from meshery.

aabidsofi19 avatar aabidsofi19 commented on July 21, 2024

@DevRish yeah thats the right approach .

from meshery.

jameshorton2337 avatar jameshorton2337 commented on July 21, 2024

@DevRish, looks like we've had a misfire on the first PR. Try again and come back quickly or let us know if you're in need of being reassigned, so that another contributor can carry this forward.

from meshery.

leecalcote avatar leecalcote commented on July 21, 2024

@DevRish you're encouraged to try again. In the meantime, as you work on it, I'll open this up for other contributors to undertake the crux of this issue, which is the conversion from one tool to the next.

from meshery.

DevRish avatar DevRish commented on July 21, 2024

Here is my second try at this issue. Summary of changes:

  • Migrated all cypress tests except commented out ones (service_mesh_configuration_management_spec.js and configuration_filters_spec.js) to playwright. Verified passing on my system.
  • Used provider None for running the tests, because the Meshery provider was giving some errors in my local instance, which I haven't been able to fix yet. However, I think the flow of the existing tests are same irrespective of provider chosen.
  • The test for visibility of Service Mesh section in indexui.spec.js is commented out because it was failing on my end, as no such section was indeed visible in the left navigation panel on the local instance.
  • In the cypress tests, verification response bodies of requests to /api/system/adapters and /api/system/adapter/manage in settings.spec.js was done using fixtures which had exact values. But I observed that the values in response body may differ depending on which adapters the user has active and running. So I have added checks for verifying structure of the objects instead of exact values.

Please review @leecalcote @jameshorton2337

from meshery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.