GithubHelp home page GithubHelp logo

[UI] Registry enhancement about meshery HOT 8 OPEN

Yashsharma1911 avatar Yashsharma1911 commented on September 28, 2024
[UI] Registry enhancement

from meshery.

Comments (8)

Yashsharma1911 avatar Yashsharma1911 commented on September 28, 2024

@dottharun I created this task to track the issue, I have added the you shared with me, please add more as you identify.

from meshery.

github-actions avatar github-actions commented on September 28, 2024

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

from meshery.

leecalcote avatar leecalcote commented on September 28, 2024

End-to-end tests needed for importing and exporting models. @dottharun @humblenginr #11555 (comment)

from meshery.

dottharun avatar dottharun commented on September 28, 2024

More Issues: @Yashsharma1911

  • Make the meshmodel details component respect the level of navigation of
    the current tree.
    • Show aggregate count of the number of components in all of the
      versioned models - for the top-level model.
  • Fix component and relationship count bug - currently both shows zero.
  • Fix initial load of models tab and with page-size large enough to always
    cover the first page.
  • Add empty state when numbered nodes in Tree like components and
    relationships becomes zero - currently this just shows zero in brackets
    (0).
  • Convert all tabs to use IntersectionObserver.
    • Currently only Models and Registrants tab uses this - and
      Components tab uses scroll based fetching.
  • Add query param for the meshmodel/models,
    meshmodels/components, meshmodels/relationships,
    meshmodels/registrants endpoints.
    • Like a "duplication-data=true" to get information about
      duplication of the entities and use those in the UI to filter and
      annotate duplicate entities.
  • Add Id based endpoints for GET requests for all Registry endpoints to allow for easy selection of entities

from meshery.

Yashsharma1911 avatar Yashsharma1911 commented on September 28, 2024

Thankyou @dottharun I have few suggestion for you to look into

  • Fix initial load of models tab and with page-size large enough to always cover the first page.

Isn't this one already fixed with having observer implemented?

  • Add empty state when numbered nodes in Tree like components and relationships becomes zero - currently this just shows zero in brackets (0).

How will you add Empty state? if number is zero they should be disabled right? I wonder if empty state in tree is unnecessary logic wdyt?

from meshery.

dottharun avatar dottharun commented on September 28, 2024
  • Fix initial load of models tab and with page-size large enough to always cover the first page.

Isn't this one already fixed with having observer implemented?

  • It still has some buggy behavior if we navigate to the page
    from the registry (by clicking). The fetching event is stuck at the
    first page. This should probably be fixed by increasing the page_size to cover
    the first page.

How will you add Empty state? if number is zero they should be disabled right? I wonder if empty state in tree is unnecessary logic wdyt?

  • Yes, this is a low priority enrichment item.

from meshery.

amitamrutiya avatar amitamrutiya commented on September 28, 2024

Hey @sudhanshutech, I would like to work on this.

from meshery.

amitamrutiya avatar amitamrutiya commented on September 28, 2024

Hey @Yashsharma1911 @sudhanshutech, I need some help from you guys. Before working on this issue, I want to confirm that I understand some problems correctly.

Fix route based details on MeshModelsDetails Component

Router should work with infiniteScroll - currently it breaks after first page

  • Screencast.from.2024-08-19.21-49-58.webm
  • I need to fix the above issues mentioned in the videos, right?

Duplication of data from endpoint should be removed

  • Make changes to the backend endpoint written in Go and remove data duplication.

Am I understand correctly ?

from meshery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.