New spends not appearing in history about nowallet

[hkrugersa]

Updated code can be viewed at https://github.com/metamarcdw/nowallet/compare/master...hkrugersa:master?diff=unified

[hkrugersa]

Thanks @metamarcdw

I've submitted the pull request, please let me know if you have any further questions.

Congrats on landing the new job and best of luck with the move!

[hkrugersa]

Hi @metamarcdw ,

First time contribution, hopefully first of many :-) I believe that I've found the source of the issue in the _dispatch_result method.

In the method, only the first transaction (i.e. history[0]) received from the get_history RPC call is checked. Hence, only the output to the address is processed and not the subsequent transaction where the funds are spent.

I tested the change on testnet and it seems to be working as can be seen in the screenshot below. You should see that the TxID is included with a height of 0 in the third block of print_loop outputs below it.

I've added the for loop and I'm ready to submit the pull request, but in keeping to the guidelines in CONTRIBUTING.md - I just wanted to get the go ahead first and/or discuss any additional changes or corrections that may be required.

[metamarcdw]

This looks good. Thanks a ton for contributing!

I am in the midst of preparing for a cross country move and a new job, so please forgive me for any delays. I am going to try to make some time to test this tomorrow afternoon. Please feel free to submit the PR whenever you like.

Thanks again!