GithubHelp home page GithubHelp logo

Comments (2)

raix avatar raix commented on May 30, 2024

Hi, thanks for reporting,
Makes sense, so we should replace window with self at https://github.com/raix/Meteor-EventEmitter/blob/master/eventemitter.client.js#L88

from meteor-eventemitter.

zocky avatar zocky commented on May 30, 2024

You would also need to move _runCallbacks inside .emit so it knows about self.

Alternatively, you could rewrite .emit and get rid of _runCallbacks completely. Something like the this should do it (I haven't tested it):

// emitter.emit(event, [arg1], [arg2], [...])#
// Execute each of the listeners in order with the supplied arguments.
EventEmitter.prototype.emit = function(eventName /* arguments */) {
  var self = this;

  // Make argument list to pass on to listeners
  var args = _.rest(arguments);

  // Construct the list of listeners to trigger
  var onceList = self._eventEmitter.onceListeners[eventName] || [];
  var onList = self._eventEmitter.onListeners[eventName] || [];
  var list = [].concat(onceList,onList);

  // Empty the once list
  self._eventEmitter.onceListeners[eventName] = [];

  // Trigger all listeners - call .apply(self,args) on each function in the list
  _.invoke(list,'apply',self,args);

  // Returns true if event had listeners, false otherwise.
  return (list.length > 0);
};

from meteor-eventemitter.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.