GithubHelp home page GithubHelp logo

Comments (6)

abernix avatar abernix commented on May 28, 2024

Yes, I've seen this and I presume it's something in our scripts doing it (probably the thing that highlights the sidebar or auto-expands the sub-headings when you're within that section?) but haven't looked into what it is yet.

from meteor-theme-hexo.

abernix avatar abernix commented on May 28, 2024

This hadn't been a more prominent problem until proxy-release-notes.md since markdown header-syntax (e.g. #, ##, ###) normally replaces symbols (something along the lines of [\W], I believe) with hyphens (-) when it generates the ids for the resulting <h#> tags.

In the case of proxy-release-notes.md (and other newer docs markdown), we manually generate the anchor to prevent it from breaking permalinks if we change the header itself, and the proxy versions are some of the only headers which utilize periods (à la, 1.0.4) causing this smooth-scroll bug to rear its head.

Anyhow, fixed with an upgrade of smooth-scroll (which is now served via CDN too). 248d0ba.

Thanks for reporting this!

from meteor-theme-hexo.

glasser avatar glasser commented on May 28, 2024

Yeah, I didn't think it was helpful to include dates in the anchors along with the version number. Thanks!

from meteor-theme-hexo.

abernix avatar abernix commented on May 28, 2024

What you did absolutely makes sense, just verbalizing the reason why this is cropping up now. I'll deploy this next week after I've bunched some more features to reduce PR/update noise.

from meteor-theme-hexo.

abernix avatar abernix commented on May 28, 2024

@glasser This is deployed now to the Engine docs! (i.e. fixed).

from meteor-theme-hexo.

glasser avatar glasser commented on May 28, 2024

Thanks!

from meteor-theme-hexo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.