GithubHelp home page GithubHelp logo

Comments (8)

jxnl avatar jxnl commented on August 22, 2024

the __getitem__ needs to check if item is an attribute and not overwrite it.
I can look into this sometime tomorrow tonight if no one else does.

from addict.

mewwts avatar mewwts commented on August 22, 2024

Yes, @jxnl, that's a good idea!

from addict.

jxnl avatar jxnl commented on August 22, 2024

#14 seems to fix the issue. let me know about any style issues

from addict.

mewwts avatar mewwts commented on August 22, 2024

This is fixed by ec26acb. Thanks @jxnl and @yedpodtrzitko

from addict.

yedpodtrzitko avatar yedpodtrzitko commented on August 22, 2024

Wait what? You consider this as resolved by raising an exception? That makes it totally unusable

Imagine the situation: I got a dictionary from a frontend and now everything explodes, because it contains items? What I am supposed to tell to the frontend guys? "You cant use items, keys, and a bunch of other stuff there, because one of our libraries doesn't support it, you dickheads!"

from addict.

mewwts avatar mewwts commented on August 22, 2024

Hey, @yedpodtrzitko. You can still insert and read keys with protected names, but you would have to do that by using the get/set item syntax.

>>> a = Dict()
>>> a['items'] = [1, 2, 3]
>>> a
{'items': [1, 2, 3]}
>>> a['items']
[1, 2, 3]

So relax. Nothing explodes.

from addict.

yedpodtrzitko avatar yedpodtrzitko commented on August 22, 2024

oh... good

from addict.

mewwts avatar mewwts commented on August 22, 2024

Hope this works for you, @yedpodtrzitko 👍

from addict.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.