GithubHelp home page GithubHelp logo

Comments (6)

hughrawlinson avatar hughrawlinson commented on May 26, 2024

Thanks for checking this out @miksago :)

What browser are you using? And what are the steps to repro bugs that you're seeing as a result of these errors?

@jakubfiala: afaik we're only outputting numbers and arrays right? I think complexSpectrum is the only one that's somewhat different in that we're outputting a multidimensional array.

from meyda.

hughrawlinson avatar hughrawlinson commented on May 26, 2024

Oh, my bad, complexSpectrum is an object.

from meyda.

hughrawlinson avatar hughrawlinson commented on May 26, 2024

Looks like all the features work on the site as long as neither loudness nor complexSpectrum are selected. I'll take a look at this now.

from meyda.

ThisIsMissEm avatar ThisIsMissEm commented on May 26, 2024

@hughrawlinson need anything from me on this?

from meyda.

jakubfiala avatar jakubfiala commented on May 26, 2024

@miksago thanks for pointing it out! this is a result of me not really worrying about any other input types when I initially built the demo just for testing, and then forgetting about this. Both CS and Loudness are objects – CS has its arrays in .real and .imag properties, and loudness is .total and .specific. Loudness should really be parametrized, so that the user selects the output, as opposed to obtaining an object with all possible outputs.

@hughrawlinson what we can do now if we want a quick fix, is just find out whether we're outputting loudness, and adjust the display method accordingly.

Also this should be the same for all browsers AFAIK.

from meyda.

jakubfiala avatar jakubfiala commented on May 26, 2024

This should now be fixed on gh-pages, will merge to master soon. Thanks again @miksago for pointing this out!

from meyda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.