GithubHelp home page GithubHelp logo

Comments (6)

hughrawlinson avatar hughrawlinson commented on May 26, 2024

Yes, that's absolutely a glaring design flaw that I missed. We should totally do this, and modify the main meyda class to use it rather than calculate the ampSpec inside the SPN callback each time. If you want to take this on, that'd be great. :shipit:

from meyda.

hughrawlinson avatar hughrawlinson commented on May 26, 2024

Oh, and while you're doing this, it'd be really great if you could look into the possibility of doing exactly the same thing with the complex spectrum?

from meyda.

jakubfiala avatar jakubfiala commented on May 26, 2024

Alright, self-assigned this. Will do the same with complex spec, too 🚀

Hopefully this will be done in the next couple of days as I kind of need it for research anyways

from meyda.

jakubfiala avatar jakubfiala commented on May 26, 2024

@hughrawlinson versioning-wise, should this end up in the next versioned release or shall we just leave it as a hotfix on the master branch?

from meyda.

hughrawlinson avatar hughrawlinson commented on May 26, 2024

@jakubfiala I switched us to using semantic versioning in meyda so that we'll be able to push small hotfixes/patches to production when we incremement the patch version. When a PR (or a group of simultaneous PRs) get merged to master, I will increment the appropriate version number, be that major, minor or patch, and push to bower and npm.

from meyda.

jakubfiala avatar jakubfiala commented on May 26, 2024

This issue is probably going to be solved in #86

Closing this now.

from meyda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.