Conversion doesn't escape reserved characters about x2js

[GoogleCodeExporter]

Basic XML character escaping functionality is available in v1.0.10.
It will be great if you could test it in your environment. Thanks!

Original comment by [email protected] on 6 Jan 2013 at 12:26

• Changed state: Done

[GoogleCodeExporter]

Wow. That was fast o__O

It almost works, but not quite. It needs to check that the tokens being escaped 
are actually strings before it does so. I have some bool values in the object 
I'm testing with, and when the xml escaping is enabled, the console output is:

TypeError: str.replace is not a function

If I test with only strings it works fine. Any other type causes problems.

You probably want to add a check like:

if(typeof(str) != "string")

before trying to escape it.

Original comment by [email protected] on 7 Jan 2013 at 4:19

[GoogleCodeExporter]

Wow. That was fast o__O

It almost works, but not quite. It needs to check that the tokens being escaped 
are actually strings before it does so. I have some bool values in the object 
I'm testing with, and when the xml escaping is enabled, the console output is:

TypeError: str.replace is not a function

If I test with only strings it works fine. Any other type causes problems.

You probably want to add a check like:

if(typeof(str) != "string")

before trying to escape it.

Original comment by [email protected] on 7 Jan 2013 at 4:20

[GoogleCodeExporter]

er, that should be something more like


if(typeof(str) == "string")

Original comment by [email protected] on 7 Jan 2013 at 4:23

[GoogleCodeExporter]

Fixed in v1.0.11. Thank you for additional check!

Original comment by [email protected] on 7 Jan 2013 at 11:25