GithubHelp home page GithubHelp logo

No changelog for version 6.0.0 about codelyzer HOT 7 OPEN

viceice avatar viceice commented on June 2, 2024 25
No changelog for version 6.0.0

from codelyzer.

Comments (7)

mgechev avatar mgechev commented on June 2, 2024 6

Hey everyone, sorry for the late response. I just saw this issue after digging into hundreds of @dependabot PRs.

We'll be moving to ESLint in the next few months and deprecating codelyzer. You'll be able to use angular-eslint, which currently has a similar feature set.

In v6 I added dependencies on Angular v9 so we can use the compiler API codelyzer understands. The pros of this approach is that as soon we don't drastically change the Angular template syntax codelyzer will work just fine with any Angular version.

The cons is that you'd now have Angular v10 and v9 in your project, which on its own will slow a little down the npm install step until we completely switch to ESLint.

from codelyzer.

Dassderdie avatar Dassderdie commented on June 2, 2024 5

Also there is ?instead? a changelog for version 5.3.0 but no version 5.3 published to npm...

from codelyzer.

aramperes avatar aramperes commented on June 2, 2024 4

The 5.3.0/6.0.0 changelog also mentions support for Angular 10, yet the project still has a hard dependency on @angular/core and @angular/compiler 9.0.0. Shouldn't those be devDependencies since v10 is supported in peerDependencies?

codelyzer/package.json

Lines 96 to 98 in 0b2e233

"dependencies": {
"@angular/core": "9.0.0",
"@angular/compiler": "9.0.0",

from codelyzer.

jimivdw avatar jimivdw commented on June 2, 2024

@aramperes I noticed the same thing. It actually causes my custom linters not to work in combination with Angular 10 (throws some type errors).

Maybe it's worth it to file this as a separate issue?

from codelyzer.

C0ZEN avatar C0ZEN commented on June 2, 2024

@jimivdw what kind of errors do you have?
I have the latest version of Angular 10.0.3 and this on 6.0.0 and everything is fine on my project.
Sounds not safe but still good to me to upgrade it.

from codelyzer.

mariusbolik avatar mariusbolik commented on June 2, 2024

Also tslint which is deprecated should be replaced by a similar tool. This was also mentioned here: #763 :)

"tslint": "^5.0.0 || ^6.0.0"

from codelyzer.

jimivdw avatar jimivdw commented on June 2, 2024

@C0ZEN seems I jumped to conclusions a bit too fast (updated my earlier comment accordingly). The type errors I got were actually related to a custom linter I have, where I import types from Angular (local, which is v10) which are different than the ones codelyzer uses (Angular v9).

A workaround for that would be to import the types from codelyzer/node_modules/@angular/compiler instead of just from @angular/compiler, but that's really not a proper solution.

from codelyzer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.