Comments (7)
Hey everyone, sorry for the late response. I just saw this issue after digging into hundreds of @dependabot PRs.
We'll be moving to ESLint in the next few months and deprecating codelyzer. You'll be able to use angular-eslint, which currently has a similar feature set.
In v6 I added dependencies on Angular v9 so we can use the compiler API codelyzer understands. The pros of this approach is that as soon we don't drastically change the Angular template syntax codelyzer will work just fine with any Angular version.
The cons is that you'd now have Angular v10 and v9 in your project, which on its own will slow a little down the npm install
step until we completely switch to ESLint.
from codelyzer.
Also there is ?instead? a changelog for version 5.3.0 but no version 5.3 published to npm...
from codelyzer.
The 5.3.0/6.0.0 changelog also mentions support for Angular 10, yet the project still has a hard dependency on @angular/core
and @angular/compiler
9.0.0. Shouldn't those be devDependencies
since v10 is supported in peerDependencies
?
Lines 96 to 98 in 0b2e233
from codelyzer.
@aramperes I noticed the same thing. It actually causes my custom linters not to work in combination with Angular 10 (throws some type errors).
Maybe it's worth it to file this as a separate issue?
from codelyzer.
@jimivdw what kind of errors do you have?
I have the latest version of Angular 10.0.3
and this on 6.0.0
and everything is fine on my project.
Sounds not safe but still good to me to upgrade it.
from codelyzer.
Also tslint
which is deprecated should be replaced by a similar tool. This was also mentioned here: #763 :)
Line 94 in 0b2e233
from codelyzer.
@C0ZEN seems I jumped to conclusions a bit too fast (updated my earlier comment accordingly). The type errors I got were actually related to a custom linter I have, where I import types from Angular (local, which is v10) which are different than the ones codelyzer uses (Angular v9).
A workaround for that would be to import the types from codelyzer/node_modules/@angular/compiler
instead of just from @angular/compiler
, but that's really not a proper solution.
from codelyzer.
Related Issues (20)
- Dependency Dashboard
- Support for Angular 10
- Update codelyzer support for Angular v13 HOT 3
- Angular 14 HOT 2
- Update Angular to resolve vulnerability CVE-2021-4231 HOT 3
- Deprecated dependency "[email protected]"
- tslint 6 compatibility HOT 5
- Support for Angular 8.x.x HOT 1
- directive-selector throws an error when it comes across an empty @Directive() HOT 2
- [feature request]: Add a new rule validate decorators
- Support Angular 10 HOT 15
- [Feature Request] Rule: Inputs, Outputs and lifecycle methods on top HOT 1
- [feature request]: Allow aria-label to suppress template-accessibility-alt-text violation
- component-class-suffix does not work. HOT 5
- 5.3.0 not published on NPM HOT 6
- How to Run Codelyzer
- @angular/core and @angular/compiler explicitly listed as dependencies in published package.json HOT 5
- [feature request]: Allow aria-label to suppress template-accessibility-elements-content violation HOT 1
- template-click-events-have-key-events throws error on anchor <a> element
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codelyzer.