Improve the extension about phpstan-drupal

[mglaman]

:) Yeah. I'm going to get creative with it. The main thing is providing dynamic return types for services. Which requires knowing where Drupal is so extensions can be discovered. Not a hard problem. Just picking the less hacky option out of the choices

[mglaman]

CompilerExtension - will PHPStan provide any way to integration with the container? Otherwise the bootstrap or autoload files have no way of interacting with PHPStan -- even if the current setup is a hack.

Global variables -- I'm looking to move from those and should have used %currentWorkingDirectory%, but "it worked" when first starting :)

[ondrejmirtes]

What exactly are you doing in the CompilerExtension? If you just need to run some code, you can create a file and put it to autoload_files in extension.neon.

[mglaman]

Drupal doesn't have all of its classes dumped to the autoloader. We need to find the Drupal root and then do namespace processing. For this I need to know the current working directory, and autoload_files nor bootstrap have access to the container to know those params without globals.

Basically the extension, right now, uses that info and pumps data into globals for use later.

[ondrejmirtes]

I see :) I'll try to come up with a solution.

[mglaman]

I'll see what I can do, as well. Now that I have PHPUnit tests it's a lot less... magical of an integration.

[ondrejmirtes]

Hi, this should help you to move the logic into autoload_files:

phpstan/phpstan@4824bba

(You should not override bootstrap, that's for the root project that uses PHPStan.)

[ondrejmirtes]

I just released 0.11.6 with this change, so you can change your code and start requiring this version :)

[mglaman]

This helped remove some of the magical globals.

However, it cannot be fully used. Parameters need to be added to the container for service detection. Opened an initial branch and experimenting.

[ondrejmirtes]

You can create some classes lazily with a factory so that parameters don’t have to initially exist.

On Fri, 10 May 2019 at 22:55, Matt Glaman ***@***.***> wrote: This helped remove some of the magical globals. However, it cannot be fully used. Parameters need to be added to the container for service detection. Opened an initial branch and experimenting. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZTOGX7S3T7ASYWJXMYGLPUXOKZANCNFSM4HEI7OXQ> .

-- Ondřej Mirtes

[mglaman]

0.12 forced the fixes :)