GithubHelp home page GithubHelp logo

mgol / angular-hint-dom Goto Github PK

View Code? Open in Web Editor NEW

This project forked from btford/angular-hint-dom

0.0 2.0 0.0 954 KB

angular-hint plugin for detecting DOM manipulations from controllers

License: Other

Shell 15.09% JavaScript 84.91%

angular-hint-dom's Introduction

Angular Hint DOM Build Status Code Climate

This hinting module is part of the overall tool AngularHint that provides advice about AngularJS best practices. Loading this module will provide warnings specific to how AngularJS applications should manipulate the DOM.

See the AngularHintDOM NPM Module.

##Usage

Install the AngularHint NPM module and use ng-hint or ng-hint-include='dom' to enable AngularHintDOM. Further installation information is available on the main AngularHint repository.

##Features

AngularJS provides a framework for separating the implementation of a web application into logical components. This separation of concerns is important for code development, maintenance and especially testing. With modular code, it is easy to implement unit tests.

However, how an application should be split into these components is not always obvious. For example, many applications built without AngularJS rely on javascript for manipulation of the DOM including dynamically adding and removing elements from the page. Naturally, an AngularJS developer might try to implement such javascript manipulation in their AngularJS controllers. As the controllers provide the logic for the views, this could seem to be a correct usage. However, AngularJS allows all such manipulation to occur through AngularJS directives in the views themselves. In fact, manipulation of DOM APIs from the controller violates the modularity between the controller and view and is against AngularJS best practices.

To help users recognize the violation of this best practice, AngularHintDOM gives warnings when DOM APIs are manipulated in AngularJS controllers.

For example, an application might seek to add items to the page based on some changing list of items:

//Application view
<!doctype html>
  <html ng-app='sample' ng-hint>
    ...
    <div id='list'></div>
    <script src="../../bower_components/angular/angular.js"></script>
    <script src="../../dist/hint.js"></script>
    ...
  </html>
//Application controller
  angular.module('sample').controller(function(){
    //Accessing the DOM API `document.getElementById()` triggers an AngularHintDOM warning
    var list = document.getElementById('list');
    var newListItem = document.createElement('div');
    newListItem.innerHTML = 'Item 1';
    list.appendChild(newListItem);
  });

This approach using document.getElementById() to access and change the DOM from within the controller is against AngularJS best practices. The correct approach would be to use the ng-repeat directive to automatically update the list in the view based on the contents of whatever data is in the list.

##Contributing

Want to improve AngularHintDOM or other facets of AngularHint? We'd love to get your help! See the Contributing Guidelines.

Copyright 2014 Google, Inc. http://angularjs.org

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

angular-hint-dom's People

Contributors

btford avatar

Watchers

 avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.