GithubHelp home page GithubHelp logo

Comments (2)

Manouchehri avatar Manouchehri commented on August 25, 2024

Closing as this is not a bug with aws4fetch, only wanted to document this issue and solution for others.

from aws4fetch.

mhart avatar mhart commented on August 25, 2024

Thanks for documenting this @Manouchehri – I must admit I've never encountered a 3xx using AWS signing before, so hadn't really thought about fetch's default behavior here.

I feel like, as you say, aws4fetch probably shouldn't do anything special here. If it tried to detect whether the user had the redirect setting unset or follow, but then behind the scenes set it to manual and intercepted, signed and made the new request – it might sound like that's the right thing to do – but aws4fetch has no idea if the URL being redirected to needs to be signed or not, even if it happened to be on the same host as the original request. So I think it's less magic to just leave it as is, and let the user implement that behavior if they want.

I'll add a note to the documentation about this when I get the chance, thanks again.

from aws4fetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.