Comments (2)
Closing as this is not a bug with aws4fetch, only wanted to document this issue and solution for others.
from aws4fetch.
Thanks for documenting this @Manouchehri – I must admit I've never encountered a 3xx using AWS signing before, so hadn't really thought about fetch's default behavior here.
I feel like, as you say, aws4fetch
probably shouldn't do anything special here. If it tried to detect whether the user had the redirect
setting unset or follow
, but then behind the scenes set it to manual
and intercepted, signed and made the new request – it might sound like that's the right thing to do – but aws4fetch
has no idea if the URL being redirected to needs to be signed or not, even if it happened to be on the same host as the original request. So I think it's less magic to just leave it as is, and let the user implement that behavior if they want.
I'll add a note to the documentation about this when I get the chance, thanks again.
from aws4fetch.
Related Issues (20)
- Support for streaming body via UNSIGNED_PAYLOAD HOT 2
- '[' and ']' should be add to encodeRfc3986()
- Range header not signable HOT 18
- How to use this service with AWS SES (Simple Email Service)? HOT 2
- Within scope to add support for R2? HOT 2
- regression 1.0.16: not possible to use in ESM build and nodejs HOT 8
- sign and fetch functions don't *exactly* match TypeScripts' types.
- Lambda Function URL decoding HOT 5
- Providing custom headers when using signQuery results in incorrect SignedHeaders HOT 8
- How to use it with React Native? HOT 1
- Race condition with ReadableStream
- Sign URLs without protocol HOT 3
- POST with empty body
- BUG: aws4fetch.authHeader excluding "content-length" and "content-type" HOT 1
- Typescript/export/module/package.json B.S. HOT 14
- Google cloud storage compatability
- crypto is not defined HOT 9
- Could not find a declaration file for module 'aws4fetch' HOT 3
- Feat: Make execute-api default service for API Gateway with custom URL HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws4fetch.