Comments (7)
you'd have to provide a working/simple example of how to reproduce this
Thanks
from dnsclient.net.
That being said, @jjxtra, there is a part in ReadLabels
which is recursive. DNS name labels can be referenced to reduce the size of the overall packet, and, each reference can again reference another, already exiting label.
If that causes an endless loop, then the data received is probably wrong or incomplete or something.
I could probably stop this after a few iterations, to prevent the stackoverflow. But you'd still get an exception..
Would be really interesting to know the server and query which causes that for you!
from dnsclient.net.
Could we terminate after 100 or 1000 iterations? If an ILogger reference is included it could log a warning with the host or query? Or maybe throw a LabelRecursionException that could be caught further down stream?
Easiest option for me is a log or throw and then it can print out the query and/or host name server used...
from dnsclient.net.
I believe this will resolve with #167 @MichaCo
from dnsclient.net.
Nice 👍 , I'll take a look later
from dnsclient.net.
Any update here @MichaCo ? Happy to help if you need it.
from dnsclient.net.
@jjxtra well this is a pretty low priority thing and I have to take some time to review your PR, and, I don't really have a lot of time atm.
I just did review it though, see comments.
During the review I had to write a unit test which actually can reproduce the StackOverflow error, so, I'd rather close your PR if you don't mind and then use my version? Unless you want to play more with it for fun.
from dnsclient.net.
Related Issues (20)
- ios build issues
- How to get the parent nameservers? HOT 1
- HasError=false / no error message when hostname (not FQDN) has no ip address HOT 2
- NameServer timed out HOT 1
- mock-friendly API for ResolveService(Async) HOT 2
- Trailing `.` in MxRecord.DomainName.Value HOT 1
- Memory-leak in latest versions in combination with full .net framework HOT 1
- Exceptions in DnsClient.LookupClient.HandleDnsResponeParseException HOT 2
- How can i set my own dns servers?
- Characters should not be escaped within the audit trail <character-string>
- Verifying MX records? HOT 1
- Incorrect usage of Name from NRPT table HOT 8
- Move cache checks outside loop in ResolveQuery and ResolveQueryAsync HOT 2
- Timeout when querying TXT records HOT 1
- Eliminate dependency on Microsoft.Win32.Registry for newer TFM HOT 1
- LookupClient.QueryAsync is not concurrency-safe HOT 2
- Reduce allocations HOT 1
- Does the Internal namespace need to have public members? HOT 2
- question re: TXT records HOT 1
- Audit Log Exception - Error querying domain check in Swedish locale - Exception Parsing Question for Audit Log. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dnsclient.net.