GithubHelp home page GithubHelp logo

Comments (5)

michael-lazar avatar michael-lazar commented on May 29, 2024

I'm unsure what you mean by this. o is currently mapped to "open the selected link in a new web browser tab". Are you saying that this shouldn't be the case?

from rtv.

Brobin avatar Brobin commented on May 29, 2024

I think he is pressing 'o' in the subreddit view and expecting it to open the submission view of the comments instead of the browser

from rtv.

5225225 avatar 5225225 commented on May 29, 2024

Yes, if it's a self post, the url is set to the comments page of the post. Opening that should open it in the program itself, instead of using a browser.

I made the changes in my own fork, but I don't know if it's the best way, as I changed open_link to check if the selection is a self post, and calling self.open_submission. There might be a cleaner way to do this.

from rtv.

michael-lazar avatar michael-lazar commented on May 29, 2024

Ok I understand now, thanks for elaborating. I appreciate hearing different viewpoints about how people are using the program. That being said, I'm not a huge fan of this suggestion. Here are the reasons why:

  1. l is already available and does exactly what you're asking for.
  2. IMO having the o key do two disjoint things is more confusing to explain to people.
  3. In some cases you might actually want to actually open the comments in your browser, I don't want to take that option away.

from rtv.

michael-lazar avatar michael-lazar commented on May 29, 2024

Closing for now, please reopen if you have additional info or ideas to add.

from rtv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.