GithubHelp home page GithubHelp logo

Comments (8)

MichaelCurrin avatar MichaelCurrin commented on May 26, 2024

Hi, thanks for the interest and suggestion.

I'll add this as something you can control in settings.

from auto-commit-msg.

MichaelCurrin avatar MichaelCurrin commented on May 26, 2024

Hi, I added a draft PR. I got this working for a narrow usecase, now need to get it to work for multiple file changes and when not using a type prefix.

from auto-commit-msg.

MichaelCurrin avatar MichaelCurrin commented on May 26, 2024

Here's how it is configured:
Screenshot_2022-07-26_17-39-33

from auto-commit-msg.

lexuzieel avatar lexuzieel commented on May 26, 2024

Hey that looks great! Sorry for late response.
I see that PR is failing on build but the logs are expired, so I cannot see them.
Could you please re-run the job?

from auto-commit-msg.

lexuzieel avatar lexuzieel commented on May 26, 2024

I have forked your version and fixed linter errors, however I was not able to build current version due to error

Error: Cannot find module 'vscode'

https://github.com/avixFF/auto-commit-msg/actions/runs/3463893007/jobs/5784743972

from auto-commit-msg.

lexuzieel avatar lexuzieel commented on May 26, 2024

Alright, so I figured out why there was build problem and it was not at all trivial.

Turns out Microsoft has updated vscode package.

This in turn required mocha downgrade to version 4
Which required rewriting tests using only test() function
That triggered linter, since it made lines greater than 100 characters long
Because of that I had to shorten some test messages

So in order to use vscode package you have to run tests inside an actual vscode instance. Document linked above explains it.
The build was failing because you were including prepareCommitMsg.ts in prepareCommitMsg.test.ts which had vscode package import that was not accessible when run with mocha from CLI.

In my branch I have changed that your mocha tests run inside vscode instance, therefore vscode package is accessible for tests.

Here is my version: lexuzieel@7440e07

from auto-commit-msg.

lexuzieel avatar lexuzieel commented on May 26, 2024

While we are at it, I would also like to add a flag to disable prefix (I don't use those for my projects). I have created a separate PR based on the latest version of my feat-titlecase branch: #86

from auto-commit-msg.

MichaelCurrin avatar MichaelCurrin commented on May 26, 2024

Thanks for the info. Reviewing your PR now

from auto-commit-msg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.