Allow customizing client-properties? about langohr

[michaelklishin]

Sure. Please note that connection name is a dedicated property for such cases and other clients, including the Java one used internally by Langohr, usually have a dedicated function for setting just that. Thank you for considering a contribution!

…

On 29 Jul 2020, at 14:42, Glen Mailer ***@***.***> wrote:  When running a server with a lot of connections from various clients and services, it can be very useful to add additional identifying information to the client-properties. This then shows up in RabbitMQ admin. The current client-properties are hard-coded: https://github.com/michaelklishin/langohr/blob/master/src/clojure/langohr/core.clj#L307-L313 Would you accept a PR that made them customizable? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[glenjamin]

Oh thanks - I'll look into that.

In my testing so far it seems that product, platform and version are the ones that appear on the RabbitMQ admin UI's connection list - which makes them the most useful ones to override IMO

[glenjamin]

From the RabbitMQ 3.6.5 release notes:

https://rabbitmq.docs.pivotal.io/36/relnotes/release-notes-rabbitmq3.6.5.html

Management Plugin Clients now can provide a human-readable connection name that will be displayed in the management UI. Currently Java, .NET and Erlang clients support this. In order to use this feature, set the connection_name key in client properties. Note that this name doesn’t have to be unique and cannot be used as a connection identifier, for example, in HTTP API requests.

[michaelklishin]

I shall respectfully disagree. At least product name and version can be used for your own app but that’s also why we support connection_name, which will be displayed in management UI and included into connection lifecycle log entries if you actually set it. I don’t think you want to override platform which is meant to be the OS. My point was that together with a way to override any properties — something that most clients allow for — we should also add a dedicated setter for just connection name.

…

On 29 Jul 2020, at 22:40, Glen Mailer ***@***.***> wrote:  Oh thanks - I'll look into that. In my testing so far it seems that product, platform and version are the ones that appear on the RabbitMQ admin UI's connection list - which makes them the most useful ones to override IMO — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[glenjamin]

Sorry yes - that's what I took away from your previous message.

My comment about connection name was for reference - as I hadn't heard of it before (last time I worked on a RabbitMQ client it didn't exist yet).

[michaelklishin]

I guess we could promote it a bit more in the [RabbitMQ] docs!