GithubHelp home page GithubHelp logo

Comments (3)

MichalLytek avatar MichalLytek commented on June 12, 2024

It's on purpose. Because of #385, I don't have time to keep this lib always up to date.
And 90% of the time, Prisma version bumps don't break stuff. So I've changed ~ to ^ to let people try to use the newest version.

Maybe there should be a better warning or disclaimer that version x.y.z is tested and supported and newer might not work?

from typegraphql-prisma.

SheaBelsky avatar SheaBelsky commented on June 12, 2024

I understand that you lack the time/support to maintain this at the same level as before. As a result, I haven't upgraded to Prisma 4.16.2 since this library doesn't explicitly support it yet, exactly for the reason in this issue. If this library only explicitly supports version 4.15, then this library should reflect that so it's clear to implementors what the expectation is.

Maybe there should be a better warning or disclaimer that version x.y.z is tested and supported and newer might not work?

NPM would take care of this based on the version range OR on peer dependencies. If this library specifies peer dependencies for a specific version of Prisma, then NPM would warn developers if they try to use an incompatible version if Prisma. You could also add some sort of manual warning, but that seems like reinventing the wheel if NPM can already do something similar.

https://nodejs.org/fa/blog/npm/peer-dependencies

from typegraphql-prisma.

MichalLytek avatar MichalLytek commented on June 12, 2024

then NPM would warn developers

No, now NPM yells and errors when you have wrong version. You have to force install the wrong package version.

from typegraphql-prisma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.