Adding New Buttons about dante

[michelson]

Hi @AdamOstrove ,

that's a very interesting approach. I will look forward of any progress on this.
Tomorrow I will play with your branch to see how it works

thanks!

[butsjoh]

+1 Any idea when this is coming to the main branch?

[michelson]

Hi @AdamOstrove.

Please check branch modular-tooltip I've came up with the following solution based on your concept design. I've decoupled the Tooltip view in widgets (image , extract & embed) which are inherited from a Dante.View.TooltipWidget object.

So now you can inherit from the new Dante.View.TooltipWidget. and create new instances of tooltip button with a custom behavior.

window.MyCustomTooltip = Dante.View.TooltipWidget.extend({
  initialize: function(opts) {
    if (opts == null) {
      opts = {};
    }
    this.icon = opts.icon || "icon-video";
    this.title = opts.title || "Add a Custom Thing!";
    this.action = opts.action || "custom-embed-simple";
    return this.current_editor = opts.current_editor;
  },
  handleClick: function(ev) {
    return alert("This is custom button with extend style");
  }
});

Then just add it as an option with the new extra_tooltip_widgets initialization attribute. It will accept an array of tooltip button objects, so you can add as many as you want without the register hassle, it will just work.

  var btn1 = new window.MyCustomTooltip

  editor = new Dante.Editor(
    {
      el: "#editor",
      upload_url: "/uploads/new.json",
      debug:  true ,
      extra_tooltip_widgets: [btn1, ...]
    }
  )
  editor.start()

I think this solution is very neat , what do you think about it ? maybe you could take this as an starting point in order to improve this solution

Best

[AdamOstrove]

@michelson

I really like this idea! It is very neat, and certainly a step in the right direction. My main concern with it is a small legacy connection between the base widgets (embeds and extracts specifically) and the Dante Core.

#embeds or extracts
if parent.hasClass("is-embedable")
  @embed_widget.getEmbedFromNode($(anchor_node))
else if parent.hasClass("is-extractable")
  @embed_extract_widget.getExtractFromNode($(anchor_node))

This check is made in Dante, so turning embeds or extracts from placeholders into realized structures and what to do with those structures is still controlled by the Dante core. As far as I can tell, this makes it impossible to make a new widget with similar behavior to the first three (placeholder followed by a complete structure) without modifying Dante code directly. Have you given any thought to removing that last legacy tie somehow?

Thanks

[michelson]

Hi @AdamOstrove , I've noted that too.

I guess we could call each embed object for specific function so when program executes handleKeyDown (checking keycode 13) , Dante core will call each embed handleKeyDown() like you have done it in your prototype. that way we will ensure that core embeds and custom embeds will be handle that events too.

how it that sounds ?

[AdamOstrove]

@michelson

That sounds good to me. I cant really think of a much better way of doing it.

[michelson]

Hi @AdamOstrove , it's finally merged and released as version 0.0.11

best!