Comments (12)
@mslarae13 @JamesTessmer this appears to be a schema issue?
The definition for SolutionComponent
has the slot compound
asserted on it, but itβs range needs to be modified to ProteolyticEnzymeEnum
in a slot_usage statement underneath slots.
from nmdc-schema.
Here is a branch for the issue
https://github.com/microbiomedata/berkeley-schema-fy24/tree/Fix-compound-range
from nmdc-schema.
Update: The enums are being enforced which I confirmed by adding an invalid data file and testing the valid ones with different values. The issue seems to be with the generated documentation saying the range is a string (which is technically true) but it doesn't show the enums being used to enforce the values.
from nmdc-schema.
@sujaypatil96 can you help sort out why the generated documentation is wrong? https://microbiomedata.github.io/berkeley-schema-fy24/SolutionComponent/
from nmdc-schema.
@sujaypatil96 can you help sort out why the generated documentation is wrong? https://microbiomedata.github.io/berkeley-schema-fy24/SolutionComponent/
Should this issue be re-assigned to @sujaypatil96? @mslarae13
from nmdc-schema.
I'm going to remove this issue from the sprint and add the backlog label to it. If it should be active in the next sprint let me know. If it should be re-assigned to
@Sujay Patil
let me know.
from nmdc-schema.
I would like for us to review the overall modeling of solutions and reagents. The range
slot_usage
s for compound
sound relatively safe to me.
from nmdc-schema.
see also (eventually!):
from nmdc-schema.
The documentation generation will be resolved with the release of LinkML version 1.7.6, until then the issue will remain open
from nmdc-schema.
@anastasiyaprymolenna does this have relevance for the re-working of ChemicalConversionProcess?
from nmdc-schema.
I'm working on a refactoring of everything solution related for Wednesday
from nmdc-schema.
compound
has been replaced by substances_used
from nmdc-schema.
Related Issues (20)
- Add PR template to `nmdc-schema`
- Finalize metatranscriptome modeling for nmdc HOT 1
- MIxS Environmental Context slot grouping
- `known_as` slot needs description and `structured_pattern` constraints
- `berkeley-schema-fy24`: id slot_usage resulting in badly minted IDs HOT 19
- `berkeley-schema-fy24`: Update `part_16` migrator to include `metatranscriptome_expression_analysis_set` collection HOT 1
- document the fact that working on a PR template is the only case in which PRs don't require review HOT 1
- Fix PR template functionality HOT 1
- update range and pattern on metagenome_annotation_id to allow metatranscriptome workflow activities
- Draft: add details to `InstrumentModelEnum`
- `berkeley`: Fix range for `was_generated_by` slot
- delete `assets/yq-for-nmdc_schema_accepting_legacy_ids.txt`
- resume efforts to detect examples coverage HOT 1
- range constraint for gene_function_id on Class FunctionalAnnotationAggMember
- `berkeley`: Fix range for `has_calibration` slot
- FileEnumType for indexed bam file
- FileEnumType needs modularization and normalization
- do we really need a `chemical_entity_set`?
- would metref meet our content and format needs as a metabolite namespace? HOT 1
- `berkeley-schema-fy24`: JSON Schema and YAML schema files are missing from `nmdc_schema` directory HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nmdc-schema.