GithubHelp home page GithubHelp logo

Comments (12)

sujaypatil96 avatar sujaypatil96 commented on July 30, 2024 1

@mslarae13 @JamesTessmer this appears to be a schema issue?

The definition for SolutionComponent has the slot compound asserted on it, but it’s range needs to be modified to ProteolyticEnzymeEnum in a slot_usage statement underneath slots.

from nmdc-schema.

JamesTessmer avatar JamesTessmer commented on July 30, 2024

Here is a branch for the issue
https://github.com/microbiomedata/berkeley-schema-fy24/tree/Fix-compound-range

from nmdc-schema.

JamesTessmer avatar JamesTessmer commented on July 30, 2024

Update: The enums are being enforced which I confirmed by adding an invalid data file and testing the valid ones with different values. The issue seems to be with the generated documentation saying the range is a string (which is technically true) but it doesn't show the enums being used to enforce the values.

from nmdc-schema.

mslarae13 avatar mslarae13 commented on July 30, 2024

@sujaypatil96 can you help sort out why the generated documentation is wrong? https://microbiomedata.github.io/berkeley-schema-fy24/SolutionComponent/

from nmdc-schema.

ssarrafan avatar ssarrafan commented on July 30, 2024

@sujaypatil96 can you help sort out why the generated documentation is wrong? https://microbiomedata.github.io/berkeley-schema-fy24/SolutionComponent/

Should this issue be re-assigned to @sujaypatil96? @mslarae13

from nmdc-schema.

ssarrafan avatar ssarrafan commented on July 30, 2024

I'm going to remove this issue from the sprint and add the backlog label to it. If it should be active in the next sprint let me know. If it should be re-assigned to
@Sujay Patil
let me know.

from nmdc-schema.

turbomam avatar turbomam commented on July 30, 2024

I would like for us to review the overall modeling of solutions and reagents. The range slot_usages for compound sound relatively safe to me.

from nmdc-schema.

turbomam avatar turbomam commented on July 30, 2024

see also (eventually!):

from nmdc-schema.

anastasiyaprymolenna avatar anastasiyaprymolenna commented on July 30, 2024

The documentation generation will be resolved with the release of LinkML version 1.7.6, until then the issue will remain open

from nmdc-schema.

mslarae13 avatar mslarae13 commented on July 30, 2024

@anastasiyaprymolenna does this have relevance for the re-working of ChemicalConversionProcess?

from nmdc-schema.

turbomam avatar turbomam commented on July 30, 2024

I'm working on a refactoring of everything solution related for Wednesday

from nmdc-schema.

turbomam avatar turbomam commented on July 30, 2024

compound has been replaced by substances_used

from nmdc-schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.