Comments (6)
OK - for now - avoid deleting branches until this is fixed, in case something needs to be restored. This seems ok as an overall plan.
from nmdc-schema.
In other words, I think the branch renaming solution would have worked; but I accidentally used the wrong branch as the new main
branch. 🤦
CC: @aclum
from nmdc-schema.
The nmdc-schema
main
branch commit history is now free of the delete operations that would have ruined berkeley-schema-fy24
The berkeley-schema-fy24
GH code page shows that it is ~ 1170 commits ahead and 0 commits behind nmdc-schema
from nmdc-schema.
This is done. Closing.
from nmdc-schema.
@eecavanna @shreddd when will you be comfortable deleting the temporary branches?
from nmdc-schema.
I'm already comfortable with them being deleted now, based on the validation we did over Zoom this morning.
I'll be even more comfortable (more comfortable than necessary, from my perspective) at the end of the sprint (i.e. in ~10 calendar days). The hypothetical scenario I think would be simplified for us if we were to wait until then is:
- Someone created a feature branch from the
main
branch (while themain
branch was in one of its temporary, problematic states in which it had 1000+ accidental commits on it). Then, that person makes a handful of commits on that feature branch. Finally, that person pushes the feature branch up to GitHub and opens a PR. - The PR shows 1000+ commits (plus the handful that person actually made)
I think if we have copies of those temporary branches around (which we currently do—they are named main-old
and main-old-2
), it will be easier for us to make sense of that PR.
I like using the end of the sprint as the milestone here because that is a milestone shared by some developers (e.g. they might open a PR for whatever they're currently working on "by then").
from nmdc-schema.
Related Issues (20)
- Docker Compose shows warning saying `version` (specifier) is obsolete
- extra leading caret in `structured_pattern`s HOT 3
- remove logic to repair curies HOT 1
- replace uses of `nmdc_schema_merged.yaml` with `nmdc_schema/nmdc_materialized_patterns.yaml` HOT 3
- force update of `urllib3` version HOT 2
- `berkeley-schema-fy24`: Schema version underlying `SchemaView` instance changes from one release to the next HOT 1
- Add PR template to `nmdc-schema`
- Finalize metatranscriptome modeling for nmdc HOT 1
- MIxS Environmental Context slot grouping
- `known_as` slot needs description and `structured_pattern` constraints
- `berkeley-schema-fy24`: id slot_usage resulting in badly minted IDs HOT 19
- `berkeley-schema-fy24`: Update `part_16` migrator to include `metatranscriptome_expression_analysis_set` collection HOT 1
- document the fact that working on a PR template is the only case in which PRs don't require review HOT 1
- Fix PR template functionality HOT 1
- update range and pattern on metagenome_annotation_id to allow metatranscriptome workflow activities
- Draft: add details to `InstrumentModelEnum`
- `berkeley`: Fix range for `was_generated_by` slot
- delete `assets/yq-for-nmdc_schema_accepting_legacy_ids.txt`
- resume efforts to detect examples coverage HOT 1
- range constraint for gene_function_id on Class FunctionalAnnotationAggMember
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nmdc-schema.