GithubHelp home page GithubHelp logo

Comments (3)

jonatan-ivanov avatar jonatan-ivanov commented on July 18, 2024

Practically, currently I see Spring Boot outputs the following metrics:
http.server.requests histogram (who has "max");
http.server.requests.max gauge.
It's not easily clear which one means what and why there are two. For example, in Grafana I just see one of them, because probably one overrides the other.

I'm not sure what is going on here, you are saying that you see two maxes but then you say you only see one? Which registry are you using?
If this is Prometheus, there should be only one max (a gauge), the histogram does not have a max and there are no overrides.

It would be great if docs provided practical example (something like saying "for example in Spring, http.server.requests.max is a time windowed max...").

Micrometer does not depend on Spring, it does not know about http.server.requests.max, that one is Spring-relates so it should live in the Spring docs (afaik it mentions it). The Micrometer docs do mention that max is a time-window max.

As I understand, Micrometer doesn't specify an exact list of metrics with their meanings (unlike OpenTelemetry), so because it's Spring who actually outputs those, it could be more issue of Spring docs that don't explain it (currently, doesn't explain anything besides the name: https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#actuator.metrics.supported.spring-mvc), so let me know if you think it's an issue for them instead, but since Micrometer mentioned already windowed max in the docs, since it provides reference implementation for some other components, and since the end goal is making it clear for users anyway, it could be worth explaining in Micrometer docs.

http.server.requests is created by Spring Framework, you should look into those docs not Spring Boot.

It's not really clear to me what doc improvements you want but please feel free to add more details to this issue and/or open a PR, we are happy to review it.

from micrometer.

github-actions avatar github-actions commented on July 18, 2024

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

from micrometer.

github-actions avatar github-actions commented on July 18, 2024

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open.

from micrometer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.