GithubHelp home page GithubHelp logo

Comments (10)

shakuzen avatar shakuzen commented on July 18, 2024 1

I've added a Frameworks section to the Migration Guide, including a sub-section for Spring Boot. Could folks who ran into this issue give us feedback on if those sections in the guide would have sufficiently explained the issue faced here? @rohan-changejar @joethehoff @IlyaLisov

from micrometer.

IlyaLisov avatar IlyaLisov commented on July 18, 2024 1

@shakuzen It is good explained and I found this really helpful. I think that sometimes some devs upgrading dependencies with minor/patch changes without any thoughts, so it could lead to such issues if there are no info in release notes
Thank you again! You helped me

from micrometer.

shakuzen avatar shakuzen commented on July 18, 2024

What version of Spring Boot are you using? Typically, if you're using Spring Boot, you should allow its dependency management to manage the versions of dependencies unless you have a reason to override it. I believe Spring Boot 3.3.0 (scheduled to be released next week) will manage Micrometer dependencies to version 1.13.0.

from micrometer.

rohan-changejar avatar rohan-changejar commented on July 18, 2024

What version of Spring Boot are you using? Typically, if you're using Spring Boot, you should allow its dependency management to manage the versions of dependencies unless you have a reason to override it. I believe Spring Boot 3.3.0 (scheduled to be released next week) will manage Micrometer dependencies to version 1.13.0.

We are using this version of spring id 'org.springframework.boot' version '3.2.5', do you see any correlation of this issue with this version?

If it is related, would propose adding this as a warning on the migration guide.

Let me know if I could be of any help here

from micrometer.

checketts avatar checketts commented on July 18, 2024

@rohan-changejar If you can provide a link to code that reproduces the issue, that could be useful. Just a simple minimal product is fine.

Often when I try to create one, the underlying bug is revealed

from micrometer.

joethehoff avatar joethehoff commented on July 18, 2024

Same problem on my side using spring-boot 3.2.5
After upgrading to 1.13 there were no output at localhost:9005/actuator/prometheus anymore.
This are the management-props of application.properties

management:
  endpoint:
    health.enabled: true
    prometheus.enabled: true
  endpoints:
    enabled-by-default: false
    web.exposure.include: info, prometheus, health
  server:
    address: 0.0.0.0
    port: 9005

In sourecode we just use static Metrics-methods like this:

Metrics.counter("xxxx").increment();

from micrometer.

rohan-changejar avatar rohan-changejar commented on July 18, 2024

@rohan-changejar If you can provide a link to code that reproduces the issue, that could be useful. Just a simple minimal product is fine.

Often when I try to create one, the underlying bug is revealed

Created a project demonstrating this issue, Github link.
You can use the main branch to reproduce the issue.
If you want to see the feature working on the previous version
please refer the branch [workingVersion](https://github.com/rohan-changejar/demo-micrometer-bug/tree/workingVersion)

on 1.12.6

image

on 1.13.0

image

from micrometer.

ttddyy avatar ttddyy commented on July 18, 2024

@rohan-changejar Have you read the "1.13 Migration Guide".
Also, this comment explains the background: #5093 (comment)

If you change the dependency from micrometer-registry-prometheus to micrometer-registry-prometheus-simpleclient, your sample works.

This is essentially a duplicate of #5093

from micrometer.

jonatan-ivanov avatar jonatan-ivanov commented on July 18, 2024

I would recommend letting Boot to set the version for libraries it has auto-configuration for (e.g. Micrometer). If you really want to migrate to Micrometer 1.13 with Bot 3.2 (btw 3.3 is coming next week with Micrometer 1.13 support), check Tadaya's comment, you need to change the name of the dependency when you change the version.

from micrometer.

jonatan-ivanov avatar jonatan-ivanov commented on July 18, 2024

Duplicate of #5093

from micrometer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.