Comments (10)
I've added a Frameworks section to the Migration Guide, including a sub-section for Spring Boot. Could folks who ran into this issue give us feedback on if those sections in the guide would have sufficiently explained the issue faced here? @rohan-changejar @joethehoff @IlyaLisov
from micrometer.
@shakuzen It is good explained and I found this really helpful. I think that sometimes some devs upgrading dependencies with minor/patch changes without any thoughts, so it could lead to such issues if there are no info in release notes
Thank you again! You helped me
from micrometer.
What version of Spring Boot are you using? Typically, if you're using Spring Boot, you should allow its dependency management to manage the versions of dependencies unless you have a reason to override it. I believe Spring Boot 3.3.0 (scheduled to be released next week) will manage Micrometer dependencies to version 1.13.0.
from micrometer.
What version of Spring Boot are you using? Typically, if you're using Spring Boot, you should allow its dependency management to manage the versions of dependencies unless you have a reason to override it. I believe Spring Boot 3.3.0 (scheduled to be released next week) will manage Micrometer dependencies to version 1.13.0.
We are using this version of spring id 'org.springframework.boot' version '3.2.5'
, do you see any correlation of this issue with this version?
If it is related, would propose adding this as a warning on the migration guide.
Let me know if I could be of any help here
from micrometer.
@rohan-changejar If you can provide a link to code that reproduces the issue, that could be useful. Just a simple minimal product is fine.
Often when I try to create one, the underlying bug is revealed
from micrometer.
Same problem on my side using spring-boot 3.2.5
After upgrading to 1.13 there were no output at localhost:9005/actuator/prometheus
anymore.
This are the management-props of application.properties
management:
endpoint:
health.enabled: true
prometheus.enabled: true
endpoints:
enabled-by-default: false
web.exposure.include: info, prometheus, health
server:
address: 0.0.0.0
port: 9005
In sourecode we just use static Metrics-methods like this:
Metrics.counter("xxxx").increment();
from micrometer.
@rohan-changejar If you can provide a link to code that reproduces the issue, that could be useful. Just a simple minimal product is fine.
Often when I try to create one, the underlying bug is revealed
Created a project demonstrating this issue, Github link.
You can use the main branch to reproduce the issue.
If you want to see the feature working on the previous version
please refer the branch [workingVersion](https://github.com/rohan-changejar/demo-micrometer-bug/tree/workingVersion)
on 1.12.6
![image](https://private-user-images.githubusercontent.com/83759161/330884578-7025c139-83fe-4f91-a37a-19fe9e6a8569.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNTM2NjUsIm5iZiI6MTcyMTI1MzM2NSwicGF0aCI6Ii84Mzc1OTE2MS8zMzA4ODQ1NzgtNzAyNWMxMzktODNmZS00ZjkxLWEzN2EtMTlmZTllNmE4NTY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE3VDIxNTYwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNmOTY4ODc0Yzk3ZDJiYTk1NjMzMWIzZDZhYzM0ODlhNjIwZmNjYTE1NjM1Zjg3YWZmNGNiNjJjN2RkMWFiNWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.n7mDrM7buS0kcNn92nUqfQD3OMiddcgSDVUFUkGT2xk)
on 1.13.0
![image](https://private-user-images.githubusercontent.com/83759161/330884855-0359eee4-abb4-4b94-ae43-2b4149e0bf2b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNTM2NjUsIm5iZiI6MTcyMTI1MzM2NSwicGF0aCI6Ii84Mzc1OTE2MS8zMzA4ODQ4NTUtMDM1OWVlZTQtYWJiNC00Yjk0LWFlNDMtMmI0MTQ5ZTBiZjJiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE3VDIxNTYwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFlZWJkOTQwZmEyMWQ1OTJkNjk3ZjQ5NjNlZWQzNDNlMjIwNzdhOWMzMTE0MTFmYmRiMDY2YjdiMjgyNDk1YWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bwRD3mJZ1omwEnPyP9D1YLl-vlJF73OViaAe97CyCIk)
from micrometer.
@rohan-changejar Have you read the "1.13 Migration Guide".
Also, this comment explains the background: #5093 (comment)
If you change the dependency from micrometer-registry-prometheus
to micrometer-registry-prometheus-simpleclient
, your sample works.
This is essentially a duplicate of #5093
from micrometer.
I would recommend letting Boot to set the version for libraries it has auto-configuration for (e.g. Micrometer). If you really want to migrate to Micrometer 1.13 with Bot 3.2 (btw 3.3 is coming next week with Micrometer 1.13 support), check Tadaya's comment, you need to change the name of the dependency when you change the version.
from micrometer.
Duplicate of #5093
from micrometer.
Related Issues (20)
- Timed annotation should consider Transactional handling HOT 1
- Add KeyValue support for Observation.Event HOT 2
- Test duplicate stops on observations HOT 1
- Backport fix AspectJ pointcut syntax HOT 3
- Adopt Stable OTEL Semantic Conventions for JVM metrics HOT 4
- io.micrometer:micrometer-observation:1.11.5 getting error with micrometer-test with version 1.12.0-SNAPSHOT with java version 17 & 21 HOT 4
- Make measured event duration accessible from outside of DefaultMeterObservationHandler HOT 2
- process_start_time_seconds HELP description inconsistency between Prometheus and micrometer HOT 1
- Make metric export filters applicable only to Dynatrace and not Spring Boot Admin (Spring Actuator) HOT 9
- Metrics in "/actuator/prometheus" are not consistent in a multi nodes environment (kubernetes) HOT 3
- Bump org.jetbrains.kotlin.jvm from 1.9.23 to 1.9.24
- Bump org.jetbrains.kotlin.jvm from 1.9.23 to 1.9.24
- zgcGenerationalTest is flaky on CI
- Support for removing custom instrumentation meters HOT 11
- Gauge API like counter / timer HOT 6
- Use Duration for @Timed SLOs instead of double HOT 2
- Add "cancelled" information to the GrpcServerObservationContext HOT 2
- Make PrometheusMeterRegistryTest less flaky
- Apply test-retry settings to all tests
- Upgrade opentelemetry-collector-contrib to 0.104.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from micrometer.