Screen out / deny histogram registrations on certain percentile ranges about micrometer

[lenin-jaganathan]

Can a MeterFilter be used for this purpose?

I guess so. Here is an example of that. Only downside I see is, is that if there is a meter filter configured after your meter filter and adds these percentiles, then you will still see the lower percentiles.

[jonatan-ivanov]

You can also do two things:

• Not register any client-side percentiles and let users set them up (if you are using Spring Boot, there is a property for that that creates a MeterFilter)
• You can use histograms so everyone can calculate whatever percentiles they want on the Prometheus server side (more expensive though)

You might also want to watch this talk and learn about why it is usually not a good idea to look at avg, median, lower percentiles in terms of latency: https://www.youtube.com/watch?v=lJ8ydIuPFeU

[murphyzlaw]

Thanks for your reply!
Can you let me know the MeterFilter assocated SB property you're talking about.
If you can humor one more question - Our current proposed approach for pure Spring Boot is to define a config class that does Metrics.globalRegistry.config().meterFilter(percentileGuardMeterFilter) (engaging our filter), and look for @SpringBootApplication annotated classes or classes with main(), and annotate to @import this class. Do you see any overall issues with this approach. We want to target both @Timed kinds of metrics, and those that are directly created as custom metrics into the global registry.

[jonatan-ivanov]

Can you let me know the MeterFilter assocated SB property you're talking about.

Go to the Spring Boot docs, browse the Common Application Properties and search on the page for the word percentiles. Or you the search box in the top left corner.

Our current proposed approach for pure Spring Boot is to define a config class that does Metrics.globalRegistry.config().meterFilter(percentileGuardMeterFilter) (engaging our filter), and look for @SpringBootApplication annotated classes or classes with main(), and annotate to @import this class. Do you see any overall issues with this approach.

Multiple issues:

1. Do not use the global (you don't need to with Spring and it can make your life hard especially for testing)
2. Read the docs about how to create your own auto-configuration, if I understand it correctly, what you are about to do is very fragile (and sorry for the better word, it's a big hack). Instead of this you can write your own auto-configuration that Spring Boot will load for you without modifying any classes.