Possible concurrency problems about micrometer

[olga-larina]

And I have a question about LongTaskTimer (xxx.active metrics). Should I create another issue for it?

micrometer/micrometer-core/src/main/java/io/micrometer/core/instrument/observation/DefaultMeterObservationHandler.java

Lines 72 to 79 in 23b6c43

	public void onStart(Observation.Context context) {
	if (shouldCreateLongTaskTimer) {
	LongTaskTimer.Sample longTaskSample = LongTaskTimer.builder(context.getName() + ".active")
	.tags(createTags(context))
	.register(meterRegistry)
	.start();
	context.put(LongTaskTimer.Sample.class, longTaskSample);
	}

LongTaskTimer is created on start of the observation with tags. But at this time in Spring we have only default tag values (for example, http status code). Is it a problem in Spring web?

[olga-larina]

And I have a question about LongTaskTimer (xxx.active metrics). Should I create another issue for it?

micrometer/micrometer-core/src/main/java/io/micrometer/core/instrument/observation/DefaultMeterObservationHandler.java

Lines 72 to 79 in 23b6c43

	public void onStart(Observation.Context context) {
	if (shouldCreateLongTaskTimer) {
	LongTaskTimer.Sample longTaskSample = LongTaskTimer.builder(context.getName() + ".active")
	.tags(createTags(context))
	.register(meterRegistry)
	.start();
	context.put(LongTaskTimer.Sample.class, longTaskSample);
	}

LongTaskTimer is created on start of the observation with tags. But at this time in Spring we have only default tag values (for example, http status code). Is it a problem in Spring web?

This question was answered in spring-projects/spring-framework#32897

[jonatan-ivanov]

Thank you for the issue. In general Observations should not be modified from multiple threads concurrently so I'm curious what you are trying to do.

volatile ObservationConvention convention ?

Why should this be volatile? The convention is set from the ctor and a setter, this should not be thread safe I think, if you have concurrency issues with it, could you please tell us what you are trying to do (a minimal java test/reproducer would help)?

ConcurrentLinkedDeque instead of ArrayDeque?

Why should this be concurrent? The deque here is a local variable, cannot be accessed from multiple threads

Everything else: I think they are the same as the convention, I don't think you should access them concurrently so they don't ned to be thread safe. If you have concurrency issues with them, could you please tell us what you are trying to do (a minimal java test/reproducer would help)?

[github-actions]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.