info command returning "Bad message" about switchtec-user

[lsgunth]

Hmm, very strange. Tho only place I can see that returns EBADMSG is in the kernel where it checks the status returned by the device to be valid:

https://github.com/Microsemi/switchtec-kernel/blob/e459e54607c31eabb0bb503040d23425e0d3ef9f/switchtec.c#L631

Do you know what kind of hardware and firmware version you have?

My guess is the hardware/firmware are responding improperly to the MRPC_I2C_TWI_PING command (possibly it is too old?) and thus we don't fall back to the gen3 return and it returns an error instead.

[arshad512]

Thanks for your response!

Hmm, very strange. Tho only place I can see that returns EBADMSG is in the kernel where it checks the status returned by the device to be valid:

I will check this part. Thanks. However, I am curious to understand. Is not the return value 0 here ? I may be wrong.

(gdb) x /12x buf
0x7fffffffde70:	0x00000000	0x63592f39	0x00179ec8	0x00000000
0x7fffffffde80:	0xffffdf28	0x00007fff	0xf7fe76c0	0x00007fff
0x7fffffffde90:	0xffffdec0	0x00007fff	0x00000008	0x00000000

Do you know what kind of hardware and firmware version you have?

# cat /sys/class/switchtec/switchtec0/fw_version 
01090063
# cat /sys/class/switchtec/switchtec0/vendor_id 
MICROSEM

My guess is the hardware/firmware are responding improperly to the MRPC_I2C_TWI_PING command (possibly it is too old?) >and thus we don't fall back to the gen3 return and it returns an error instead.

This is what I saw a while back when debugging. I thought I should share it here. It looks to recognize "GEN3" correctly. I am not sure if this is what you are mentioning here.

(gdb) p ldev
$5 = (struct switchtec_linux *) 0x648330
(gdb) p *ldev
$6 = {dev = {device_id = 34098, gen = SWITCHTEC_GEN3, var = SWITCHTEC_PFX, pax_id = -1, local_pax_id = -1, partition = 0, partition_count = 1, 
    boot_phase = SWITCHTEC_BOOT_PHASE_FW, name = "/dev/switchtec0", '\000' <repeats 4080 times>, gas_map = 0x0, gas_map_size = 0, ops = 0x644080 <linux_ops>}, fd = 3}

[lsgunth]

The return value in the buffer is zero. But it's not likely valid if the status is the wrong value.

Is your hardware indeed GEN3? The switchtec_dev stuff you are printing may not be correct given the switchtec_get_device_info() call failed.

What is in:

/sys/class/switchtec/switchtec0/component_id

[arshad512]

What is in:
/sys/class/switchtec/switchtec0/component_id

# cat /sys/class/switchtec/switchtec0/component_id
PM8532

Is your hardware indeed GEN3? The switchtec_dev stuff you are printing may not be correct given the switchtec_get_device_info() call failed.

I thought the switchtec_get_device_info() is already populated before calling switchtec_cmd()/linux_cmd(). I will revisit my understanding again.

[lsgunth]

Yup, this is definitely GEN3 hardware. Perhaps a patch such as this will fix the issue:

diff --git a/lib/switchtec.c b/lib/switchtec.c
index 23b570fc8d30..4640532f5f00 100644
--- a/lib/switchtec.c
+++ b/lib/switchtec.c
@@ -1755,7 +1755,7 @@ int switchtec_get_device_info(struct switchtec_dev *dev,
                        *rev = (dev_info >> 8) & 0x0f;
                if (gen)
                        *gen = map_to_gen((dev_info >> 12) & 0x0f);
-       } else if (ERRNO_MRPC(errno) == ERR_CMD_INVALID) {
+       } else if (errno == EBADMSG || ERRNO_MRPC(errno) == ERR_CMD_INVALID) {
                if (phase)
                        *phase = SWITCHTEC_BOOT_PHASE_FW;
                if (gen)

[arshad512]

Yup, this is definitely GEN3 hardware. Perhaps a patch such as this will fix the issue:

diff --git a/lib/switchtec.c b/lib/switchtec.c
index 23b570fc8d30..4640532f5f00 100644
--- a/lib/switchtec.c
+++ b/lib/switchtec.c
@@ -1755,7 +1755,7 @@ int switchtec_get_device_info(struct switchtec_dev *dev,
                        *rev = (dev_info >> 8) & 0x0f;
                if (gen)
                        *gen = map_to_gen((dev_info >> 12) & 0x0f);
-       } else if (ERRNO_MRPC(errno) == ERR_CMD_INVALID) {
+       } else if (errno == EBADMSG || ERRNO_MRPC(errno) == ERR_CMD_INVALID) {
                if (phase)
                        *phase = SWITCHTEC_BOOT_PHASE_FW;
                if (gen)

@lsgunth , Thanks for the patch. I will try out and let you know.

[arshad512]

Your patch worked. Thanks @lsgunth !

# ./switchtec info /dev/switchtec0
/dev/switchtec0:
    Generation:  GEN3
    HW Revision: Unknown
    Variant:     PFX
    Device ID:   0x8532
    FW Version:  1.09 B063

This issue can be closed.