GithubHelp home page GithubHelp logo

Comments (14)

matthiaswenz avatar matthiaswenz commented on May 28, 2024 19

Agree, this can definitely be improved so we are better supporting mono repo scenarios etc.
In terms of putting this on the roadmap there is definitely multiple factors that we look for, effort required is one thing, but also customer interest in general and how the solution we can think of plays with other items on our roadmap and our existing feature set.

It'd be great to get more clarity on the feature set you all would like to see us support. To get a better understanding of this (of course, not making any promises about an ETA or exact feature set):

  • React with 🎉if you would be happy with a solution where we allow you to restrict builds to only be triggered when a commit is within the path of the project that we found in your repo,
  • React with 🚀 if you need an option to configure path filters matching certain patterns, i.e. using wildcards, per build configuration

from appcenter.

vpavlushkov avatar vpavlushkov commented on May 28, 2024 1

I understand that the feature is quite clear and there is not much to discuss about it, but closing it due to inactivity sounds like a wrong call to me. I'd rather have it implemented. 😉

from appcenter.

rnystrom avatar rnystrom commented on May 28, 2024 1

We have iOS, Android, and documentation all in one repo. Kicking off multiple builds for a README.md seems wasteful and noisy. We could split the repo into 3, but that adds a bit more project-mgmt overhead.

from appcenter.

caiofbpa avatar caiofbpa commented on May 28, 2024 1

React with 🎉if you would be happy with a solution where we allow you to restrict builds to only be triggered when a commit is within the path of the project that we found in your repo,

About this, we have a Xamarin solution where we have an Android project, an iOS project and a Shared project. If any files in Shared change, I want both Android and iOS to be built. So it's much better if I can manually specify the paths to be watched for changes that trigger a build.

from appcenter.

patniko avatar patniko commented on May 28, 2024

Thanks for the feature request! Path filters are something we use ourselves on a daily basis. We'll continue to track interest on this one.

from appcenter.

stale avatar stale commented on May 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further requests are made to keep it open.

from appcenter.

matthiaswenz avatar matthiaswenz commented on May 28, 2024

@vpavlushkov Thanks for reminding us about this. While this is currently not on our immediate roadmap, how important is a fully customizable path filter setting for the build configuration to you, rather than say - a pre-defined path filter based on the folder in your repository where we found your project?

from appcenter.

vpavlushkov avatar vpavlushkov commented on May 28, 2024

@ranterle "importance" is a relative term. 😉

We can certainly survive without that feature as it only causes extra build time but no real harm. Even if App Center starts a build which is totally redundant, one can cancel it manually. Hence, I'd say it is "nice to have" feature. However, I am so used to have this feature in different CI servers that not having this basic feature is odd.

I would also presume the complexity of implementing this feature is pretty small. Why would not we add it to the queue, without adding it to a certain milestone? Then somebody could pick it up while being free between bigger tasks.

from appcenter.

anthonyhumphreys avatar anthonyhumphreys commented on May 28, 2024

Hi, on a similar note I've just opened an Issue here: #930

This issue makes me think about the situation from a different angle though. It would be amazing if I could specify that only changes to the android/* or ios/* for example would trigger a native build. If my JS changes I already have CI set up which triggers a codepush rollout.

Will be keen to track this one.

from appcenter.

anthonyhumphreys avatar anthonyhumphreys commented on May 28, 2024

We have iOS, Android, and documentation all in one repo. Kicking off multiple builds for a README.md seems wasteful and noisy. We could split the repo into 3, but that adds a bit more project-mgmt overhead.

Agree with this. This is the norm with React Native projects especially and I know lots of orgs who are moving towards monorepos so this would be a huge win for users who fit those use-cases.

from appcenter.

CatalinVoss avatar CatalinVoss commented on May 28, 2024

Would still love to see this in December 2020

from appcenter.

 avatar commented on May 28, 2024

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

from appcenter.

 avatar commented on May 28, 2024

This issue will now be closed because it hasn't had any activity for 15 days after stale. Please feel free to open a new issue if you still have a question/issue or suggestion.

from appcenter.

venkatsunilm avatar venkatsunilm commented on May 28, 2024

Exactly, that is my requirement. Any updates on this?
The below script is not working as expected.

Please paste the script sample?

Trigger the build only, if the changes are related to:

FolderA/

FolderB/

Directory.Build.props file

git log -m -1 --name-only --pretty="format:" HEAD | grep -q '^(FolderA/|FolderB/|Directory.Build.props)' || exit 1

The selected project in the app center configuration for the master branch is ProjectName.Android.csproj

from appcenter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.