Unnecessary confirmation of location about botbuilder-location

[kgrashad]

Hi @craigomatic , we can provide an option to allow you to skip this last confirmation. I am adding this to our Feb release.

[garypretty]

Would also be good to be able to override this confirmation message if we don't want to skip it.

[kgrashad]

@garypretty You can already do this through providing a LocationResourceManager to LocationDialog and overriding the 'ConfirmationAsk' property.

[haligasd]

thank you. was going to ask for this today. biggest deal is when we use this with facebook and we just want their lat / lng (which is all we get anyway) but we don't want another confirm question in the flow

[garypretty]

Hi. Is this release imminent?

[haligasd]

+1. We really need this as well

[craigomatic]

I've coded this for C# on the V2 branch if it's helpful: https://github.com/craigomatic/BotBuilder-Location/tree/V2

Will do NodeJS later today also.

[haligasd]

great i am using c# when will it make it into nuget?

[kgrashad]

Thanks @craigomatic . V2 Is still has sometime to be released. If you would like you can create this as a hotfix to master branch. Please call your branch (hotfix/skip-final-confirmation-option). I will review it and merge it. Thanks!

[haligasd]

cool i see the pull request. how does this work from here? will this be a 1.2 release?

[eswarkp]

May i know in which release this change will be available to install through npm?

[kgrashad]

@eswarkp I am planning to release this to npm tomorrow (Thursday March 2nd)

[haligasd]

and nuget?

[kgrashad]

npm released version 1.1.0
nuget should be release within a day or two max.

[HemalR]

+1 to this - building a bot that needs location but not for package shipping. The thread seems to suggest that this has now been made optional - is there a link to the documentation on how to make this optional that someone can point me to?

Thanks in advance!

[haligasd]

here is the commit

craigomatic@be1b3e9

just a flag you pass in the constructor

LocationOptions.SkipFinalConfirmation

[haligasd]

@kgrashad any updates on csharp release?

[kgrashad]

@haligasd released on https://www.nuget.org/packages/Microsoft.Bot.Builder.Location/1.2.0 Can you please give it a try and confirm that everything is working smoothly for you?

[haligasd]

@kgrashad works awesome!! thank you