[NodeJS] EntityRecognizer.resolveTime() doesn't handle all LUIS placeholder dates & times about botframework-sdk

[inna12]

There is another issue with datetime recognition. When LUIS return the following response e.g

"entities": [
{
"entity": "20 may 2016",
"type": "builtin.datetime",
"startIndex": 28,
"endIndex": 38,
"resolution": {
"date": "2016-05-20"
}
},
{
"entity": "22 may 2016",
"type": "builtin.datetime",
"startIndex": 45,
"endIndex": 55,
"resolution": {
"date": "2016-05-22"
}
},
{
"entity": "paris",
"type": "builtin.geography",
"startIndex": 17,
"endIndex": 21,
"score": 0.968967259
}
]

The type is 'builtin.datetime' and EntityRecognizer doesn't resolve the time. I assume that it expects 'builtin.datetime.date' type.

[Stevenic]

What do you get back in this case? I would have expected it to find the first one but not the second.

Line 105
switch (entity.resolution.resolution_type || entity.type) { case 'builtin.datetime.date': case 'builtin.datetime.time':

If type is 'builtin.datetime' like in my case, then it would not be resolved.

[Stevenic]

I see... Have you tried adding an additional case statement directly to the JS of the module? Just curious if that fixes things. They may have changed the entity titles on us. I can look into this too but it may be a bit.

[Stevenic]

I've checked in a fix for this. Will be in the next release of the SDK coming out shortly.

[v-thgratMSGit]

Closing this issue. Please open a new issue for further discussion if necessary. Thanks!