GithubHelp home page GithubHelp logo

Comments (6)

MicrosoftIssueBot avatar MicrosoftIssueBot commented on May 12, 2024

This is your friendly Microsoft Issue Bot. I created this issue automatically as requested by a team member.

from calculator.

 avatar commented on May 12, 2024

This pitch looks like it has everything it needs for review. In the meantime, we'll keep this idea open for discussion so the community has the chance to provide feedback. Check out our New Feedback Process for more info on the user-centered process we follow for new feature development.

from calculator.

 avatar commented on May 12, 2024

We reviewed the pitch and would love to explore this idea further! The pitch is a great start, but there are still some open questions. I am moving this issue into planning to iron out some of those details and I created calculator-specs/multipleInstances to track progress. A human will follow up with some feedback on your pitch shortly. Keep in mind that not all ideas that make it into the planning phase are guaranteed to make it to release. For more information on next steps, check out our spec workflow.

from calculator.

grochocki avatar grochocki commented on May 12, 2024

There are a number of open questions we have with this one and some trade offs to consider against the current multi-window approach. I know @mcooley and @HowardWolosky have some thoughts here, so I will let them chime in.

from calculator.

mcooley avatar mcooley commented on May 12, 2024

@HowardWolosky and I talked offline about the tradeoffs involved here:

Benefits:

  • Data protection. If there is a bug in the app that takes down an instance of the calculator, the other instances wouldn’t go down at the same time, losing the work that users had in their other instances. This isolation would have offered us some protection against a crash we introduced recently with always-on-top mode, if we hadn't caught that bug in time.

Drawbacks:

  • Perf overhead of extra processes (for both calc.exe and the runtime broker). We'd need to measure to see what the actual impact is on memory usage and the time required to start up a secondary window.
  • Sharing state between windows is harder. For example, let's say we chose to implement settings in the app, like theme selection. It’s a better experience if it changes all the windows at once, and that’s hard if they’re multiple processes.
  • New concurrency issues introduced. For example, how do you make sure that a new request for the currency converter rates doesn’t get downloaded each time the user opens a new calc window?

from calculator.

rkarman avatar rkarman commented on May 12, 2024

I was not aware of this issue asking for multi-instancing when I was looking at prototyping this functionality, so I have not taken into account the discussion here around pros/cons, potential impact for future features, etc.

However, I did code it up because of other reasons, so if anyone wants to check out my prototype, provide feedback on the approach I've taken, point out where there might be dragons, use it as a template for brining the functionality into main, or simply use it for investigations into the topics identified in this thread (perf overhead, currency converter rate syncs, etc.) feel free to spelunk the following branch on my fork of Calculator: https://github.com/rkarman/calculator/tree/rkarman/multiinstancing

from calculator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.