GithubHelp home page GithubHelp logo

Comments (6)

lostintangent avatar lostintangent commented on May 12, 2024 1

Hey! Yep I totally agree with you on this, this is just a bug :) I'll try to get this fixed in the next couple of days. In the meantime, I'd love to hear how your presentation goes tomorrow πŸ‘

from codetour.

lostintangent avatar lostintangent commented on May 12, 2024 1

@BrianRosamilia Yep, I completely agree! I just wanted to verify that the tour was a sub-directory of the repo, since that would ensure that the relative path would be "stable" for other people when they clone the repo and try to play the tour back. I'll tackle this item ASAP πŸ‘

from codetour.

BrianRosamilia avatar BrianRosamilia commented on May 12, 2024

Hey @lostintangent. Didn't see anywhere else to give feedback so I'll do it here

I think everyone really enjoyed the code tour! And it helped me stay focused and made it so I didn't miss anything while presenting code (maybe even more important).

One suggestion that would have really helped me and I think would be amazing and really set this project ahead of traditional presentation tools :

I was glad to see the tour steps support markdown.

So when I type npm run storybook it shows how I expect it and how another developer would like to read it.

But it would be even cooler if typing that was translated to

▢️ npm run storybook

And clicking the play button would actually run the task. It was slightly cumbersome to use my (extremely loud) mechanical keyboard to show a few new npm tasks. It would've been great to just click a button and show them running. Anyway, not sure if you are thinking about adding language/platform specific tools, but I hope you do so that things like this are possible. Thanks again for this project πŸ˜„

from codetour.

lostintangent avatar lostintangent commented on May 12, 2024

@BrianRosamilia Yeah I definitely think this feature enhancement would make sense. Would you mind creating a new issue to track that seperately?

Also regarding your original request: is the parent folder a git repo? And NewThing and My.Config are child directories of it?

from codetour.

BrianRosamilia avatar BrianRosamilia commented on May 12, 2024

In my original example, the parent directory was the root of the git repository and the code tour was a couple of folders deeper in that project (because it was an introduction to react for a focused part of the codebase)

The same thing happens on my mac, with the latest version as well fyi. If I am in an azure function app deep in my repo and I create a code tour there and I add a step to something like my license or readme, it's an absolute path.

IMO, I don't think it should be assumed that our .vscode folder is always in the root of the git repo. There are a lot of monorepos out there!

from codetour.

lostintangent avatar lostintangent commented on May 12, 2024

The fix for this was just checked in and will be shipped later this afternoon πŸ‘ Let me know if it works as expected. Thanks!

from codetour.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.