Clang on windows fails to compile about directxtk

[walbourn]

For Windows I'm assuming use of MSVC or MSVC-like compiler: cl.exe, clang-cl, icl.exe, icx.exe.

I could potentially update DirectXMath to use fully qualified name resolution in these cases if that would help.

[walbourn]

The use of Internal in multiple contexts is the problem.

Ok, I propose that I change the DirectXMath library to use DirectX::MathInternal, and DirectX Tool Kit for DX11 & DX12 to use DirectX::DX1?::ToolKitInternal.

That should work, yes?

[joshuamaiche]

I tried it, and unfortunately fully-qualified name resolution won't work.

namespace DirectX
{
    namespace Internal {}
    inline namespace DX11 { namespace Internal {} }
}

means that while DirectX::DX11::Internal is not ambiguous, DirectX::Internal is.

The only solution that worked for me was just getting rid of the ambiguity. If DX11::Internal really is internal, is there a big risk to its name being changed? I was able to get DirectXTK compiling on clang by changing DX11::Internal to DX11::InlinedInternal in ScreenGrab.cpp and WICTextureLoader.cpp, but I'm not sure if there are consequences I'm not seeing.

Let me know if you want me to put up a PR with those changes.

[joshuamaiche]

That should fix it, thanks!