GithubHelp home page GithubHelp logo

Comments (7)

badrishc avatar badrishc commented on May 7, 2024 1

Good points, yes adv-file-ops may be possible to eliminate. We actually need to convert the IDevice implementation (the main user of adv-file-ops) to be platform agnostic without losing perf when on Windows, i.e., continue to use the native Windows API as we do currently, in that setting. Would be nice to see a pull request for this.

As for, readtsc, actually it is not required in core at all: it was used only for latency testing because Stopwatch was too slow when measuring latency of individual ops. I will move readtsc to benchmark/eliminate it entirely.

from faster.

jahunter-m avatar jahunter-m commented on May 7, 2024

Good suggestion, thanks. Performance between C++ and C# versions is effectively the same. So far, we have not discovered a technique that works in C++ that we have not been able to implement in C#.

from faster.

jahunter-m avatar jahunter-m commented on May 7, 2024

We should add that to the README, as you suggest.

from faster.

kasajian avatar kasajian commented on May 7, 2024

That's actually very useful to know -- thanks for the prompt feedback.

from faster.

dzmitry-lahoda avatar dzmitry-lahoda commented on May 7, 2024

Could it be possible to eliminate C++ code?

  1. https://github.com/Microsoft/FASTER/blob/master/cs/src/native/adv-file-ops/adv-file-ops.cpp

Via https://twitter.com/xoofx/status/1031645672821469187

  1. https://github.com/Microsoft/FASTER/blob/master/cs/src/native/readtsc/readtsc.cpp

I guess need to create issue request for

https://github.com/dotnet/corefx/tree/master/src/Common/src/CoreLib/System/Runtime/Intrinsics/X86

from faster.

badrishc avatar badrishc commented on May 7, 2024

Updated README, closing.

from faster.

vibeeshan025 avatar vibeeshan025 commented on May 7, 2024

Is it true to mac OS as well, When i run the provided sample project in mac, everything is working except (at least there is no any exception), i didn't see any file on the disk.

from faster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.