[Bug]: MenuPopover consumes the Esc keydown event but doesn't stop propagation about fluentui

[eridanurce]

This seems to be the root cause for the event being propagated: #29262
@bsunderhus can you provide some insight into why this change was made?

[bsunderhus]

Hey @eridanurce, few reasons:

1. Stopping propagation of events might be problematic on the design system level, as we're assuming too much of how an application might consume the event.
   • it is quite simple to prevent the event on user side to avoid conflicting behaviour. Meanwhile if we stop propagation we're basically denying an event for the user, which might be cumbersome on some edge cases scenarios (there are some application level tools that consume keypress/click events from the body and then process what's happening based on that)
2. To be more similar to what the native <dialog> element does. There's no stop propagation for the closing of a modal in the Escape press. Preventing the event is enough to stop the modal from closing, here's an example
   • By following the same pattern as dialog does we bridge for a more future proof solution where one day (🙏) we might be able to use native <dialog>
3. The not official popover attribute also would work similar to what a native <dialog> does.

Note: I'm aware that a popover and a dialog are not equivalent, but the native <dialog> element is the closest we have on a native level to build a popover/modal

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fluent UI!