Comments (3)
I also tried it with raw Modal
where this issue doesn't happen - https://codepen.io/hajekj/pen/qBwdEpJ?editors=0010
from fluentui.
Hi @hajekj, your example is using appendChild
to modify the DOM of a react-controlled element, which is not allowed in React. You need to add content using React elements instead of appending DOM nodes.
https://react.dev/learn/manipulating-the-dom-with-refs#best-practices-for-dom-manipulation-with-refs
from fluentui.
Hello @behowell, thank you for the response. I understand that this shouldn't be done, however - the same operation works perfectly fine when using Modal
directly, the issue is just when using Dialog
. My case unfortunately requires modifying the DOM, since I am rendering some dynamic iframe
elements within the Dialog
(now Modal
), and keeping it within React would result in really complex solution. So that's just to add context why I am going this way.
The use of Modal
is perfectly fine solution for me, but I think there are some shenanigans going on, on maximazing browser window with Dialog.
from fluentui.
Related Issues (20)
- [chore]: migrate Dialog to use @fluentui/react-motions-preview
- [chore]: migrate InlineDrawer & OverlayDrawer to use @fluentui/react-motions-preview
- [chore]: migrate Toast to use @fluentui/react-motions-preview HOT 1
- [chore]: deprecate @fluentui/react-motion-preview HOT 1
- [chore]: migrate Popover to use @fluentui/react-motions-preview
- [Feature]: introduce motionSlot() and necessary types HOT 1
- [Feature]: create Vite starter template & run project tests against it
- [Bug]: Toast action button color contrast HOT 5
- The builds are broken HOT 4
- [Bug]: Type 'IStyleSet' is not generic.
- [Bug]: `swc-plugin-de-indent-template-literal` doesn't work with new swc
- [Bug]: @fluentui/web-components - web-components-v3 - css variable token resolutions (output) has changed HOT 2
- [Bug]: InfoLabel doesn't close when clicking on the icon again HOT 1
- [Feature]: makeStyles should accept for function style HOT 2
- [Bug]: GroupedList returning to the initalScrollPosition when scrolling down and unable to select last file HOT 6
- [Feature]: InlineDrawer should be able to be rendered as an 'aside' element HOT 1
- [Feature]: Add Navbar component
- [Feature]: Add a `Navbar` component HOT 1
- [Bug]: `List` requires explicit `data-is-scrollable` to be defined when rendered inside `Modal` HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluentui.