GithubHelp home page GithubHelp logo

Comments (3)

hajekj avatar hajekj commented on May 29, 2024

I also tried it with raw Modal where this issue doesn't happen - https://codepen.io/hajekj/pen/qBwdEpJ?editors=0010

from fluentui.

behowell avatar behowell commented on May 29, 2024

Hi @hajekj, your example is using appendChild to modify the DOM of a react-controlled element, which is not allowed in React. You need to add content using React elements instead of appending DOM nodes.
https://react.dev/learn/manipulating-the-dom-with-refs#best-practices-for-dom-manipulation-with-refs

from fluentui.

hajekj avatar hajekj commented on May 29, 2024

Hello @behowell, thank you for the response. I understand that this shouldn't be done, however - the same operation works perfectly fine when using Modal directly, the issue is just when using Dialog. My case unfortunately requires modifying the DOM, since I am rendering some dynamic iframe elements within the Dialog (now Modal), and keeping it within React would result in really complex solution. So that's just to add context why I am going this way.

The use of Modal is perfectly fine solution for me, but I think there are some shenanigans going on, on maximazing browser window with Dialog.

from fluentui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.