GithubHelp home page GithubHelp logo

Comments (3)

smhigley avatar smhigley commented on July 23, 2024

@kolaps33 I can't repro this on the docs site on Chrome or Edge (both v126) on Windows, Firefox v127 on Windows, Edge v125 on Mac, or Chrome (canary) v128 on Mac. I'm trying all the following on the Combobox docs page:

  • scrolling down partway through the page, clicking to set focus nav start point, then tabbing to comboboxes
  • tabbing through all comboboxes, starting from the top of the page
  • Doing both of the above, and also opening a combobox somewhere partway down the page after tabbing to it

Is there something you're doing to get this behavior that I've missed? Also, could you provide browser & version info?

from fluentui.

lgoeckener avatar lgoeckener commented on July 23, 2024

@smhigley Hi, I can reproduce it and figured out where the issue comes from but don't know how to fix it, yet.

See: https://codesandbox.io/p/sandbox/fluentui-issues-31814-4thsym

It seems to be part of the useActiveDescendant hook in the @fluentui/react-aria dep. More precisely it is due to this MR #31158.

The findScrollableParent method recursively searches for a parent element that is overflowing vertically and scrolls to the top of it. Unfortunately this parent element does not necessarily is in context within the combobox itself. For example it is a wrapper div that contains multiple forms or elements.

edit:
Actually, I guess #31415 should be the fix for this misbehavior. Can you give a rough estimation on when this might be released with an update of the react-components?

edit 2:
The current bugfix release (9.54.3) brings a new prop to the Combobox component that works around this issue. Not a real fix as it decreases UX but at least it is usable again using that property.
@kolaps33 Does that prop also work for your case?

from fluentui.

lgoeckener avatar lgoeckener commented on July 23, 2024

This actually also happens for the TagPicker when the inline prop is used. The "workaround" using disableAutoFocus doesn't help here.

from fluentui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.