GithubHelp home page GithubHelp logo

Comments (3)

cclauson avatar cclauson commented on May 23, 2024 1

Hi Taylor, thanks so much for the reply. :)

I was actually just about to repost and withdraw this item. The reason is that based on more prototyping, passing the SharedTree across the iframe boundary no longer looks like the best way to provide host-component iframe isolation, so I no longer think any SharedTree changes will be needed.

To try to reexplain why this happens, though--when a sourced iframe is loaded, it has its own JS execution context and initializes its own versions of the modules, and as such the global functions there are not referentially equal to the global functions in the parent frame. In the scenario I was referring two above, the Forest constructor is called once in one JS execution context and another time in a different one, resulting in Forests that fail if diff'd.

Sorry for the randomization. I can provide exact call stacks on a different channel if there's still any interest in this, but again right now it looks like we're okay for our goals.

Thanks and best wishes,
Cooper

from fluidframework.

taylorsw04 avatar taylorsw04 commented on May 23, 2024

@cclauson can you give a bit more detail (such as a scenario and call stack) around how this happens? How does the diffAgainst method end up being invoked in such a way that two b-trees with different (referentially) comparators are diff'd?

from fluidframework.

taylorsw04 avatar taylorsw04 commented on May 23, 2024

No problem, let us know if you have other questions, and good luck!

from fluidframework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.