Comments (3)
Hi Taylor, thanks so much for the reply. :)
I was actually just about to repost and withdraw this item. The reason is that based on more prototyping, passing the SharedTree across the iframe boundary no longer looks like the best way to provide host-component iframe isolation, so I no longer think any SharedTree changes will be needed.
To try to reexplain why this happens, though--when a sourced iframe is loaded, it has its own JS execution context and initializes its own versions of the modules, and as such the global functions there are not referentially equal to the global functions in the parent frame. In the scenario I was referring two above, the Forest constructor is called once in one JS execution context and another time in a different one, resulting in Forests that fail if diff'd.
Sorry for the randomization. I can provide exact call stacks on a different channel if there's still any interest in this, but again right now it looks like we're okay for our goals.
Thanks and best wishes,
Cooper
from fluidframework.
@cclauson can you give a bit more detail (such as a scenario and call stack) around how this happens? How does the diffAgainst
method end up being invoked in such a way that two b-trees with different (referentially) comparators are diff'd?
from fluidframework.
No problem, let us know if you have other questions, and good luck!
from fluidframework.
Related Issues (20)
- Move to semver >= 7.5.2
- ActivityTimeout event handling behavior not consistent in Deli HOT 2
- Deprecate mergeTree's findTile method HOT 1
- 6.1 release blocker: Add removed telemetry items HOT 1
- Remove type parameter from IntervalCollection's add method HOT 1
- Shredded summary upload service fails on compressed binary summary blobs. HOT 3
- Copy of the container with compressed binary summaries is failing. HOT 6
- Memory leak related to unbounded creation of debug loggers HOT 1
- Stop requiring guestDisplayName as pre-condition for requestSocketToken: true as part of joinSession payload HOT 2
- Browser - Database updates on a separate thread HOT 2
- SharedMatrix undefined cell values HOT 7
- Need to bump axios to 1.6.0+ (and test) to address vulnerability HOT 7
- Misbehaving driver can cause Fluid to hang on container open HOT 7
- Blazor SDK HOT 1
- Use @fluidframework/azure-client can not create container and get Error: 0x883 at app.js:125 HOT 3
- Intervals not at expected location sometimes after undo-ing HOT 3
- Issue at container connection : Provided user was not an "AzureUser" HOT 1
- Container issues at connection HOT 9
- Error fetching checkpoint for any document causes rest of the batch to fail in deleteSummarizedOps HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluidframework.