Use a specific version of unittest-cpp about gsl

[neilmacintosh]

We are upstreaming the changes currently.

Sent from my Windows Phone

---

From: Kylo Ginsbergmailto:[email protected]
Sent: ‎9/‎24/‎2015 3:11 PM
To: Microsoft/GSLmailto:[email protected]
Subject: [GSL] Use a specific version of unittest-cpp (#47)

Currently the README says to clone https://github.com/Microsoft/unittest-cpphttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fMicrosoft%2funittest-cpp&data=01%7c01%7cNeil.MacIntosh%40microsoft.com%7c6af4cf65bfec44c305ca08d2c52d1179%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=TfINZr2zK67HT8vJShn7dKcmNDL%2fHf18uwIvJ4QEq2I%3d, which means a given SHA of GSL may produce different test results on different days if/as unittest-cpp gets new commits.

Two related questions then:

• can we use a git submodule to pin to a particular SHA of unittest-cpp? Or some other mechanism?
• is Microsoft going to maintain its fork of unittest-cpp or is it upstreaming its changes?

—
Reply to this email directly or view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fMicrosoft%2fGSL%2fissues%2f47&data=01%7c01%7cNeil.MacIntosh%40microsoft.com%7c6af4cf65bfec44c305ca08d2c52d1179%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=bl3N7jLEv9MlR7y0wnYOr71MiBPh7wVOZ0r2N4tDZ2Q%3d.