Determine package interface about ifc

[GabrielDosReis]

Should the printer also be installed? If yes, should it also be made available via the CMake package (e.g. via a IFC_PRINTER_EXECUTABLE variable)? I have not yet looked at its output, so I don't know if it's useful for scripting.

The direction we are envisioning for command-line utilities is to have subcommands of ifc.exe a la GIT. So, for now don't make the printer available via CMake package yet. In fact, don't install the printer yet.

[GabrielDosReis]

I believe the package MicrosoftIFC, and target name MicrosoftIFC::SDK sound great!

[friendlyanon]

Should the printer also be installed? If yes, should it also be made available via the CMake package (e.g. via a IFC_PRINTER_EXECUTABLE variable)? I have not yet looked at its output, so I don't know if it's useful for scripting.

[friendlyanon]

Oh my goodness. There goes me trying to figure out signing commits.

[GabrielDosReis]

@friendlyanon - it looks like merging your PR makes CodeQL automatic run fails. They claim they can no longer auto build with the following command:

cmake -DCMAKE_VERBOSE_MAKEFILE=ON -DBUILD_DOCS=OFF -DCATKIN_ENABLE_TESTING=OFF -DBUILD_DOCUMENTATION=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS=  -DCMAKE_C_FLAGS=

The error from the log is:

  CMake Error at CMakeLists.txt:19 (find_package):
    By not providing "FindMicrosoft.GSL.cmake" in CMAKE_MODULE_PATH this
    project has asked CMake to find a package configuration file provided by
    "Microsoft.GSL", but CMake did not find one.
  
    Could not find a package configuration file provided by "Microsoft.GSL"
    with any of the following names:
  
      Microsoft.GSLConfig.cmake
      microsoft.gsl-config.cmake
  
    Add the installation prefix of "Microsoft.GSL" to CMAKE_PREFIX_PATH or set
    "Microsoft.GSL_DIR" to a directory containing one of the above files.  If
    "Microsoft.GSL" provides a separate development package or SDK, be sure it
    has been installed.

Any idea how to fix this?

[friendlyanon]

Either by using vcpkg or passing CMAKE_MODULE_PATH as suggested in the PR.

[GabrielDosReis]

Either by using vcpkg or passing CMAKE_MODULE_PATH as suggested in the PR.

Yeah, but that workflow is automatically run based on build system definition. The CI for release build is successful without needing anything additional. Could you have a look at the CodeQL workflow?

[friendlyanon]

Based on the documentation, a build.bat and build.sh script needs to be added ot the root of the project.

[GabrielDosReis]

Based on the documentation, a build.bat and build.sh script needs to be added ot the root of the project.

Thanks. I converted the implicit CodeQL build into an explicit workflow in the proposed PR #41 . Please, could you rebase your proposed fix on that PR? You can push (not force push) to that branch. Thanks!