UiaOperationScope.ForEach fetches the array element as const about microsoft-ui-uiautomation

[michaelDCurran]

the change would be as follows:

diff --git a/src/UIAutomation/UiaOperationAbstraction/UiaOperationAbstraction.h b/src/UIAutomation/UiaOperationAbstraction/UiaOperationAbstraction.h
index eb831d4..86c843d 100644
--- a/src/UIAutomation/UiaOperationAbstraction/UiaOperationAbstraction.h
+++ b/src/UIAutomation/UiaOperationAbstraction/UiaOperationAbstraction.h
@@ -2375,7 +2375,7 @@ namespace UiaOperationAbstraction
                 [&]() { index += 1; } /* modification */,
                 [&]() /* body */
                 {
-                    const auto element = array.GetAt(index);
+                    auto element = array.GetAt(index);
                     body(element);
                 });
         }

[michaelDCurran]

I'm also happy to accept an answer such that it is recommended that all Uia* types should always be accepted by value in functions, but in this case I'd appreciate a clear explanation as to why.

[beweedon]

Hmm, thanks for the feedback! Honestly, my guess as to why we made that const is just that we're getting the array item by value from GetAt and didn't think too hard about what the signature of body would be.

I think I agree with you that it shouldn't be const. That way we allow body to have whatever signature it wants, which matches the capabilities of normal C++ foreach loops (i.e. the item can be const auto, const auto&, auto& etc.).

@pengyuanjin @mavangur @zhayuli Do you have any particular thoughts on this?

[beweedon]

@michaelDCurran I'd say go ahead and put up a PR for this if you want (along with some tests validating multiple constness-es). Otherwise we'll get to it when we have the chance.