Numerous build errors after latest update about ms-tpm-20-ref

[jordanrh1]

Was building fine (except for -Wexpansion-to-defined warnings) as of d979cae.

[amarochk]

TravisCI build passes for x64 and i386 Linux build configurations. I'm quite confident that the merge did not contain any changes that could specifically affect the ARM architecture. So, something is probably wrong with your build environment. In particular, both RSA_PRIVATE_SIZE and PRIVATE_VENDOR_SPECIFIC_BYTES are defined in Implementation.h. And the latter is included by all reference implementation source files.

[jordanrh1]

Have you tried building for OPTEE with ARM64? Is OPTEE build succeeding for you?

TA_DEV_KIT_DIR=path/to/export-ta_arm64 TA_CPU=cortex-a53 CROSS_COMPILE=aarch64-linux-gnu- \
make -C ms-tpm-20-ref/Samples/ARM32-FirmwareTPM/optee_ta/fTPM

[amarochk]

No, wedo not maintain the build of components in the Samples folder. Feel free to fixthe build issue and submit the fix, if any is necessary. -Andrey On Tuesday, February 19, 2019, 4:44:17 PM PST, Jordan Rhee <[email protected]> wrote: Have you tried building for OPTEE with ARM64? Is OPTEE build succeeding for you? TA_DEV_KIT_DIR=path/to/export-ta_arm64 TA_CPU=cortex-a53 CROSS_COMPILE=aarch64-linux-gnu- \ make -C ms-tpm-20-ref/Samples/ARM32-FirmwareTPM/optee_ta/fTPM — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[jbech-linaro]

Inline with what @jordanrh1 said, I experience the same issues (arm32 build) when following the instructions as provided by this git. I've bisected the commit that introduces the build regression to:

5847c02ff793114343dc18e92e60e2919fadc0b8 is the first bad commit                                                                                                                                                   
commit 5847c02ff793114343dc18e92e60e2919fadc0b8                                                                                                                                                                    
Author: Andrey Marochko <[email protected]>                                                                                                                                                            
Date:   Fri Feb 8 13:28:00 2019 -0800                                                                                                                                                                              
                                                                                                                                                                                                                   
    Rev. 1.52.                                                                                                                                                                                                     
    - X.509 support                                                                                                                                                                                                
    - RSA keys representation optimized                                                                                                                                                                            
                                                                                                                                                                                                                   
:100644 100644 883ea24e738d315d3d951c111545ce2cbb93fa35 8c151f4a8437f069cc0abf524b701d416eb44b18 M      .gitignore                                                                                                 
:040000 040000 fa7aac36d722c87f95e1ca5f77066660e2b3e26f 69b4c619b2c0eb94beeb3896bf020d156b902229 M      TPMCmd

Everything prior to this works fine when following the instructions in this git. That commit is huge, so I haven't been able to figure out what is going wrong.

[jbech-linaro]

I'm not sure how this is supposed to work, but it looks like there are lots of differences between these two files

./Samples/ARM32-FirmwareTPM/optee_ta/fTPM/reference/include/Implementation.h
./TPMCmd/tpm/include/Implementation.h

What is the reason for having them both? Should they be more or less identical? They looked much more similar on the old version (that doesn't have a build regression). It's clear that we get undeclared variables when compiling the optee_ta, since indeed Implementation.h are missing many of the defines that are being used.

[amarochk]

Hi Joakim,

Yes, the reason of the build failure is that the OPTEE source tree uses a (slightly) modified copy of Implementation.h instead of including the latter and then redefining some of its macro symbols (mostly supported algorithms, AFAIK). Devs who maintain the OPTEE code are aware of the issue and were going to fix it. Meanwhile you could try to replace the OPTEE Implementation.h in with the new one. Also, if it matters for your build, you may want to make sure that the set of supported SHA algorithms, ECC curves, and RSA key sizes matches what is in the current OPTEE version.