Build fails, protobuf needs to handle russian characters in the path of build command about onnxruntime

[snnn]

We haven't tried to build onnxruntime when "-DUNICODE -D_UNICODE" is enabled. Would you like to help us? We need to add a new cmake option 'onnxruntime_UNICODE', like protobuf has 'protobuf_UNICODE'. And also a few code changes would be needed.

[yuslepukhin]

@MironAtHome Let's make it clear, you are attempting to run protoc on files that reside in paths that have UNICODE characters within them. Was protobuf code written in a way that it can handle UNICODE characters? Addining _DUNICODE switches to the command line is not enough.
-DUNICODE is a Microsoft specific switch which may affect lots of stuff , but then again, affect nothing depending on the way code is written.

I took a brief look at protobuf code on GitHub and it looks like it is written in a way that it supports Unicode paths regardless of -DUNICODE presence at least here:
https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/io/io_win32.cc#L317

But it requires that the rest of the code treats path strings as UTF-8 encoding, otherwise it will attempt to convert to a codepage CP_ACP in this case, this is almost never what you want. You will notice that
https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/io/io_win32.cc#L383
takes a flag bool inUtf8 that denotes the string conversion from multibyte to widechar which is UTF-16 on Windows.

Bottom line, if you are able to build protobuf outside onnxruntime in way that it handles UNICODE paths, we will make sure it does the same within onnxruntime.

[MironAtHome]

Just found your comments. Will review at home tonight what is new in the build ( if anything ) and where I have left the project off when worked on it.
I think I fixed it back than but need to take a look.

[faxu]

@MironAtHome is this still relevant and require fixing?

[stale]

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

[stale]

This issue has been automatically closed due to inactivity. Please reactivate if further support is needed.